Re: [PATCH v3 03/21] hw/virtio: fix some coding style issues

[Jason Wang]

在 2022/7/27 03:21, Alex Bennée 写道:
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>


Acked-by: Jason Wang <jasowang@redhat.com>


> ---
>   hw/virtio/vhost-user.c | 7 ++++---
>   1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c
> index 75b8df21a4..55fce18480 100644
> --- a/hw/virtio/vhost-user.c
> +++ b/hw/virtio/vhost-user.c
> @@ -200,7 +200,7 @@ typedef struct {
>       VhostUserRequest request;
>   
>   #define VHOST_USER_VERSION_MASK     (0x3)
> -#define VHOST_USER_REPLY_MASK       (0x1<<2)
> +#define VHOST_USER_REPLY_MASK       (0x1 << 2)
>   #define VHOST_USER_NEED_REPLY_MASK  (0x1 << 3)
>       uint32_t flags;
>       uint32_t size; /* the following payload size */
> @@ -208,7 +208,7 @@ typedef struct {
>   
>   typedef union {
>   #define VHOST_USER_VRING_IDX_MASK   (0xff)
> -#define VHOST_USER_VRING_NOFD_MASK  (0x1<<8)
> +#define VHOST_USER_VRING_NOFD_MASK  (0x1 << 8)
>           uint64_t u64;
>           struct vhost_vring_state state;
>           struct vhost_vring_addr addr;
> @@ -248,7 +248,8 @@ struct vhost_user {
>       size_t             region_rb_len;
>       /* RAMBlock associated with a given region */
>       RAMBlock         **region_rb;
> -    /* The offset from the start of the RAMBlock to the start of the
> +    /*
> +     * The offset from the start of the RAMBlock to the start of the
>        * vhost region.
>        */
>       ram_addr_t        *region_rb_offset;