[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: virtio: why no full reset on virtio_set_status 0 ?
From: |
Claudio Fontana |
Subject: |
Re: virtio: why no full reset on virtio_set_status 0 ? |
Date: |
Fri, 29 Jul 2022 12:19:18 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 |
On 7/29/22 12:13, Michael S. Tsirkin wrote:
> On Fri, Jul 29, 2022 at 11:46:05AM +0200, Claudio Fontana wrote:
>>>> @@ -2025,7 +2031,6 @@ void virtio_reset(void *opaque)
>>>> VirtioDeviceClass *k = VIRTIO_DEVICE_GET_CLASS(vdev);
>>>> int i;
>>>>
>>>> - virtio_set_status(vdev, 0);
>>>> if (current_cpu) {
>>>> /* Guest initiated reset */
>>>> vdev->device_endian = virtio_current_cpu_endian();
>>>> --
>>>> 2.26.2
>>>
>>> As you say this is incomplete ... bout could you share a bit more
>>> of what issue does this address?
>>>
>>
>> Hi, the problem I am trying to address is a segfault in OVS/dpdk that looks
>> like this:
>
> Sorry I was not clear. What I mean is, you don't yet know why does removing
> virtio_set_status call here prevent the crash in ovs, do you?
>
I have no idea. Trying to collect logs to figure things out, but as mentioned
the logs easily hide the issue.
Likely there is just more to study here.
- Re: virtio: why no full reset on virtio_set_status 0 ?, (continued)
- Re: virtio: why no full reset on virtio_set_status 0 ?, Michael S. Tsirkin, 2022/07/27
- Re: virtio: why no full reset on virtio_set_status 0 ?, Jason Wang, 2022/07/27
- Re: virtio: why no full reset on virtio_set_status 0 ?, Claudio Fontana, 2022/07/28
- Re: virtio: why no full reset on virtio_set_status 0 ?, Claudio Fontana, 2022/07/28
- Re: virtio: why no full reset on virtio_set_status 0 ?, Claudio Fontana, 2022/07/28
- Re: virtio: why no full reset on virtio_set_status 0 ?, Cornelia Huck, 2022/07/28
- Re: virtio: why no full reset on virtio_set_status 0 ?, Claudio Fontana, 2022/07/31
- Re: virtio: why no full reset on virtio_set_status 0 ?, Michael S. Tsirkin, 2022/07/28
- Re: virtio: why no full reset on virtio_set_status 0 ?, Claudio Fontana, 2022/07/29
- Re: virtio: why no full reset on virtio_set_status 0 ?, Michael S. Tsirkin, 2022/07/29
- Re: virtio: why no full reset on virtio_set_status 0 ?,
Claudio Fontana <=
- Re: virtio: why no full reset on virtio_set_status 0 ?, Alex Bennée, 2022/07/29
- Re: virtio: why no full reset on virtio_set_status 0 ?, Claudio Fontana, 2022/07/29
- Re: virtio: why no full reset on virtio_set_status 0 ?, Claudio Fontana, 2022/07/31
- Re: virtio: why no full reset on virtio_set_status 0 ?, Michael S. Tsirkin, 2022/07/28
Re: virtio: why no full reset on virtio_set_status 0 ?, Michael S. Tsirkin, 2022/07/27