qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] migration/ram: Fix memory leak when using x-ignore-shared


From: Nikolay Borisov
Subject: [PATCH] migration/ram: Fix memory leak when using x-ignore-shared
Date: Fri, 16 Sep 2022 11:44:42 +0300

During ram initialization for migration dirty/clear bitmaps are
allocated for all migratable blocks, irrespective of their shared
status. However, during ram migration cleanup those bitmaps are freed
only for those blocks which aren't shared, in case x-ignore-shared
capability is used. This leads to a situation where the bitmaps aren't
freed for such blocks.

Fix this by switching the cleanup code to also free bitmaps for all
migratable blocks.

Signed-off-by: Nikolay Borisov <nborisov@suse.com>
---
 migration/ram.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/migration/ram.c b/migration/ram.c
index dc1de9ddbc68..2e40166d2f9e 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -2678,7 +2678,7 @@ static void ram_save_cleanup(void *opaque)
         }
     }
 
-    RAMBLOCK_FOREACH_NOT_IGNORED(block) {
+    RAMBLOCK_FOREACH_MIGRATABLE(block) {
         g_free(block->clear_bmap);
         block->clear_bmap = NULL;
         g_free(block->bmap);
-- 
2.34.1




reply via email to

[Prev in Thread] Current Thread [Next in Thread]