Re: [PULL 00/21] NBD and miscellaneous patches for 2023-06-01

[Eric Blake]

On Thu, Jun 01, 2023 at 08:58:46PM -0700, Richard Henderson wrote:
> On 6/1/23 15:02, Eric Blake wrote:
> > Eric Blake (21):
> >        iotests: Fix test 104 under NBD
> >        qcow2: Explicit mention of padding bytes
> >        test-cutils: Avoid g_assert in unit tests
> >        test-cutils: Use g_assert_cmpuint where appropriate
> >        test-cutils: Test integral qemu_strto* value on failures
> >        test-cutils: Test more integer corner cases
> >        cutils: Fix wraparound parsing in qemu_strtoui
> >        cutils: Document differences between parse_uint and qemu_strtou64
> >        cutils: Adjust signature of parse_uint[_full]
> >        cutils: Allow NULL endptr in parse_uint()
> >        test-cutils: Add coverage of qemu_strtod
> >        test-cutils: Prepare for upcoming semantic change in qemu_strtosz
> >        test-cutils: Refactor qemu_strtosz tests for less boilerplate
> >        cutils: Allow NULL str in qemu_strtosz
> >        numa: Check for qemu_strtosz_MiB error
> >        test-cutils: Add more coverage to qemu_strtosz
> >        cutils: Set value in all qemu_strtosz* error paths
> >        cutils: Set value in all integral qemu_strto* error paths
> >        cutils: Use parse_uint in qemu_strtosz for negative rejection
> >        cutils: Improve qemu_strtod* error paths
> >        cutils: Improve qemu_strtosz handling of fractions
> 
> This is failing on Windows (32 and 64-bit):
> 
> https://gitlab.com/qemu-project/qemu/-/jobs/4399466166#L3524
> https://gitlab.com/qemu-project/qemu/-/jobs/4399466165#L3332
> 
> |  21/135 /cutils/qemu_strtol/overflow -
> ERROR:../tests/unit/test-cutils.c:1387:test_qemu_strtol_overflow: assertion
> failed (res == LONG_MIN): (2147483647 == -2147483648) FAIL
> 
> It seems to have returned LONG_MAX instead of LONG_MIN.

Gah.  I see the problem; it is a copy/paste typo in part of
test-cutils.c guarded by 'if (LONG_MAX == INT_MAX)' and therefore
doesn't fire on platforms with 64-bit long.  Will respin the pull
request to fix it.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org