Re: [PATCH 1/3] meson.build: Group the UI entries in a separate summary section

[Philippe Mathieu-Daudé]

On 2/6/23 19:18, Thomas Huth wrote:
> Let's make it easier for the users to spot UI-related entries in
> the summary of the meson output.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>   meson.build | 35 +++++++++++++++++++++--------------
>   1 file changed, 21 insertions(+), 14 deletions(-)
>
> diff --git a/meson.build b/meson.build
> index a61d3e9b06..4a20a2e712 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -4243,32 +4243,44 @@ summary_info += {'rng-none':          
> get_option('rng_none')}
>   summary_info += {'Linux keyring':     have_keyring}
>   summary(summary_info, bool_yn: true, section: 'Crypto')
>   
> -# Libraries
> +# UI
>   summary_info = {}
>   if targetos == 'darwin'
>     summary_info += {'Cocoa support':           cocoa}
> -  summary_info += {'vmnet.framework support': vmnet}
>   endif
>   summary_info += {'SDL support':       sdl}
>   summary_info += {'SDL image support': sdl_image}
>   summary_info += {'GTK support':       gtk}
>   summary_info += {'pixman':            pixman}
>   summary_info += {'VTE support':       vte}
> +summary_info += {'PNG support':       png}
> +summary_info += {'VNC support':       vnc}
> +if vnc.found()
> +  summary_info += {'VNC SASL support':  sasl}
> +  summary_info += {'VNC JPEG support':  jpeg}
> +endif
> +summary_info += {'spice protocol support': spice_protocol}
> +if spice_protocol.found()
> +  summary_info += {'  spice server support': spice}
> +endif
> +summary_info += {'curses support':    curses}
> +summary_info += {'brlapi support':    brlapi}
> +summary(summary_info, bool_yn: true, section: 'User interface')
> +
> +# Libraries
> +summary_info = {}
> +if targetos == 'darwin'
> +  summary_info += {'vmnet.framework support': vmnet}
> +endif
> +summary_info = {}

Conditional to dropping the previous line:
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

>   summary_info += {'slirp support':     slirp}
>   summary_info += {'libtasn1':          tasn1}
>   summary_info += {'PAM':               pam}
>   summary_info += {'iconv support':     iconv}
> -summary_info += {'curses support':    curses}
>   summary_info += {'virgl support':     virgl}
>   summary_info += {'blkio support':     blkio}
>   summary_info += {'curl support':      curl}
>   summary_info += {'Multipath support': mpathpersist}
> -summary_info += {'PNG support':       png}
> -summary_info += {'VNC support':       vnc}
> -if vnc.found()
> -  summary_info += {'VNC SASL support':  sasl}
> -  summary_info += {'VNC JPEG support':  jpeg}
> -endif
>   if targetos not in ['darwin', 'haiku', 'windows']
>     summary_info += {'OSS support':     oss}
>     summary_info += {'sndio support':   sndio}
> @@ -4283,7 +4295,6 @@ if targetos == 'linux'
>   endif
>   summary_info += {'Pipewire support':   pipewire}
>   summary_info += {'JACK support':      jack}
> -summary_info += {'brlapi support':    brlapi}
>   summary_info += {'vde support':       vde}
>   summary_info += {'netmap support':    have_netmap}
>   summary_info += {'l2tpv3 support':    have_l2tpv3}
> @@ -4295,10 +4306,6 @@ summary_info += {'PVRDMA support':    have_pvrdma}
>   summary_info += {'fdt support':       fdt_opt == 'disabled' ? false : fdt_opt}
>   summary_info += {'libcap-ng support': libcap_ng}
>   summary_info += {'bpf support':       libbpf}
> -summary_info += {'spice protocol support': spice_protocol}
> -if spice_protocol.found()
> -  summary_info += {'  spice server support': spice}
> -endif
>   summary_info += {'rbd support':       rbd}
>   summary_info += {'smartcard support': cacard}
>   summary_info += {'U2F support':       u2f}