Re: [PATCH 2/3] meson.build: Group the network backend entries in a separate summary section

[Philippe Mathieu-Daudé]

On 2/6/23 19:18, Thomas Huth wrote:
> Let's make it easier for the users to spot network-related entries
> in the summary of the meson output.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>   meson.build | 13 ++++++++-----
>   1 file changed, 8 insertions(+), 5 deletions(-)
>
> diff --git a/meson.build b/meson.build
> index 4a20a2e712..c64ad3c365 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -4267,13 +4267,19 @@ summary_info += {'curses support':    curses}
>   summary_info += {'brlapi support':    brlapi}
>   summary(summary_info, bool_yn: true, section: 'User interface')
>   
> -# Libraries
> +# Network backends
>   summary_info = {}
>   if targetos == 'darwin'
>     summary_info += {'vmnet.framework support': vmnet}
>   endif
> -summary_info = {}

Ah, this should be squashed in the previous patch.

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

>   summary_info += {'slirp support':     slirp}
> +summary_info += {'vde support':       vde}
> +summary_info += {'netmap support':    have_netmap}
> +summary_info += {'l2tpv3 support':    have_l2tpv3}
> +summary(summary_info, bool_yn: true, section: 'Network backends')
> +
> +# Libraries
> +summary_info = {}
>   summary_info += {'libtasn1':          tasn1}
>   summary_info += {'PAM':               pam}
>   summary_info += {'iconv support':     iconv}
> @@ -4295,9 +4301,6 @@ if targetos == 'linux'
>   endif
>   summary_info += {'Pipewire support':   pipewire}
>   summary_info += {'JACK support':      jack}
> -summary_info += {'vde support':       vde}
> -summary_info += {'netmap support':    have_netmap}
> -summary_info += {'l2tpv3 support':    have_l2tpv3}
>   summary_info += {'Linux AIO support': libaio}
>   summary_info += {'Linux io_uring support': linux_io_uring}
>   summary_info += {'ATTR/XATTR support': libattr}