[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 02/10] configure: rename --enable-pypi to --enable-download,
From: |
Alex Bennée |
Subject: |
Re: [PATCH 02/10] configure: rename --enable-pypi to --enable-download, control subprojects too |
Date: |
Mon, 05 Jun 2023 11:28:22 +0100 |
User-agent: |
mu4e 1.11.6; emacs 29.0.91 |
Paolo Bonzini <pbonzini@redhat.com> writes:
> The behavior of --{enable,disable}-pypi is similar to that of
> -Dwrapmode={default,nodownload} respectively. In particular,
> in both cases a feature needs to be explicitly enabled for the
> dependency to be downloaded.
>
> So, use a single option to control both cases. Now, --enable-slirp
> will trigger cloning and building of libslirp if the .pc file
> is not found on the machine.
>
> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
- [PATCH v2 00/10] meson: replace submodules with wrap files, Paolo Bonzini, 2023/06/05
- [PATCH 02/10] configure: rename --enable-pypi to --enable-download, control subprojects too, Paolo Bonzini, 2023/06/05
- Re: [PATCH 02/10] configure: rename --enable-pypi to --enable-download, control subprojects too,
Alex Bennée <=
- [PATCH 03/10] git-submodule: allow partial update of .git-submodule-status, Paolo Bonzini, 2023/06/05
- [PATCH 01/10] configure: remove --with-git= option, Paolo Bonzini, 2023/06/05
- [PATCH 04/10] build: log submodule update from git-submodule.sh, Paolo Bonzini, 2023/06/05
- [PATCH 07/10] pc-bios/s390-ccw: always build network bootloader, Paolo Bonzini, 2023/06/05