|
From: | Thomas Huth |
Subject: | Re: [PATCH 01/10] configure: remove --with-git= option |
Date: | Mon, 5 Jun 2023 13:17:45 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 |
On 05/06/2023 11.52, Paolo Bonzini wrote:
The scenario for which --with-git= was introduced was to use a SOCKS proxy such as tsocks. However, this was back in 2017 when QEMU's submodules used the git:// protocol, and it is not as important when using the "smart HTTP" backend; for example, neither "meson subprojects download" nor scripts/checkpatch.pl do not obey the GIT environment variable.
Either "neither ... nor" or "not", but not both, please. With the sentenced fixed: Reviewed-by: Thomas Huth <thuth@redhat.com>
[Prev in Thread] | Current Thread | [Next in Thread] |