qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 10/23] q800: reimplement mac-io region aliasing using IO m


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH v3 10/23] q800: reimplement mac-io region aliasing using IO memory region
Date: Mon, 5 Jun 2023 14:43:41 +0200
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.11.2

On 4/6/23 15:14, Mark Cave-Ayland wrote:
The current use of aliased memory regions causes us 2 problems: firstly the
output of "info qom-tree" is absolutely huge and difficult to read, and
secondly we have already reached the internal limit for memory regions as
adding any new memory region into the mac-io region causes QEMU to assert
with "phys_section_add: Assertion `map->sections_nb < TARGET_PAGE_SIZE'
failed".

Implement the mac-io region aliasing using a single IO memory region that
applies IO_SLICE_MASK representing the maximum size of the aliased region and
then forwarding the access to the existing mac-io memory region using the
address space API.

Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
---
  hw/m68k/q800.c         | 100 +++++++++++++++++++++++++++++++++--------
  include/hw/m68k/q800.h |   1 +
  2 files changed, 82 insertions(+), 19 deletions(-)

Out of curiosity, is mac-io an I/O bus, rather than a MMIO device?



reply via email to

[Prev in Thread] Current Thread [Next in Thread]