[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 16/17] parallels: Incorrect condition in out-of-image check
From: |
Hanna Czenczek |
Subject: |
[PULL 16/17] parallels: Incorrect condition in out-of-image check |
Date: |
Mon, 5 Jun 2023 17:45:40 +0200 |
From: Alexander Ivanov <alexander.ivanov@virtuozzo.com>
All the offsets in the BAT must be lower than the file size.
Fix the check condition for correct check.
Signed-off-by: Alexander Ivanov <alexander.ivanov@virtuozzo.com>
Reviewed-by: Denis V. Lunev <den@openvz.org>
Message-Id: <20230424093147.197643-13-alexander.ivanov@virtuozzo.com>
Reviewed-by: Hanna Czenczek <hreitz@redhat.com>
Signed-off-by: Hanna Czenczek <hreitz@redhat.com>
---
block/parallels.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/parallels.c b/block/parallels.c
index 84d1d045ad..7c263d5085 100644
--- a/block/parallels.c
+++ b/block/parallels.c
@@ -457,7 +457,7 @@ parallels_check_outside_image(BlockDriverState *bs,
BdrvCheckResult *res,
high_off = 0;
for (i = 0; i < s->bat_size; i++) {
off = bat2sect(s, i) << BDRV_SECTOR_BITS;
- if (off > size) {
+ if (off + s->cluster_size > size) {
fprintf(stderr, "%s cluster %u is outside image\n",
fix & BDRV_FIX_ERRORS ? "Repairing" : "ERROR", i);
res->corruptions++;
--
2.40.1
- Re: [PULL 05/17] parallels: Out of image offset in BAT leads to image inflation, (continued)
- [PULL 08/17] parallels: create parallels_set_bat_entry_helper() to assign BAT value, Hanna Czenczek, 2023/06/05
- [PULL 06/17] parallels: Fix high_off calculation in parallels_co_check(), Hanna Czenczek, 2023/06/05
- [PULL 09/17] parallels: Use generic infrastructure for BAT writing in parallels_co_check(), Hanna Czenczek, 2023/06/05
- [PULL 07/17] parallels: Fix image_end_offset and data_end after out-of-image check, Hanna Czenczek, 2023/06/05
- [PULL 14/17] parallels: Move statistic collection to a separate function, Hanna Czenczek, 2023/06/05
- [PULL 15/17] parallels: Replace qemu_co_mutex_lock by WITH_QEMU_LOCK_GUARD, Hanna Czenczek, 2023/06/05
- [PULL 12/17] parallels: Fix statistics calculation, Hanna Czenczek, 2023/06/05
- [PULL 11/17] parallels: Move check of cluster outside image to a separate function, Hanna Czenczek, 2023/06/05
- [PULL 17/17] qcow2: add discard-no-unref option, Hanna Czenczek, 2023/06/05
- [PULL 16/17] parallels: Incorrect condition in out-of-image check,
Hanna Czenczek <=
- [PULL 13/17] parallels: Move check of leaks to a separate function, Hanna Czenczek, 2023/06/05
- [PULL 10/17] parallels: Move check of unclean image to a separate function, Hanna Czenczek, 2023/06/05
- Re: [PULL 00/17] Block patches, Richard Henderson, 2023/06/05