[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 09/17] parallels: Use generic infrastructure for BAT writing in pa
From: |
Hanna Czenczek |
Subject: |
[PULL 09/17] parallels: Use generic infrastructure for BAT writing in parallels_co_check() |
Date: |
Mon, 5 Jun 2023 17:45:33 +0200 |
From: Alexander Ivanov <alexander.ivanov@virtuozzo.com>
BAT is written in the context of conventional operations over the image
inside bdrv_co_flush() when it calls parallels_co_flush_to_os() callback.
Thus we should not modify BAT array directly, but call
parallels_set_bat_entry() helper and bdrv_co_flush() further on. After
that there is no need to manually write BAT and track its modification.
This makes code more generic and allows to split parallels_set_bat_entry()
for independent pieces.
Signed-off-by: Alexander Ivanov <alexander.ivanov@virtuozzo.com>
Reviewed-by: Denis V. Lunev <den@openvz.org>
Message-Id: <20230424093147.197643-6-alexander.ivanov@virtuozzo.com>
Reviewed-by: Hanna Czenczek <hreitz@redhat.com>
Signed-off-by: Hanna Czenczek <hreitz@redhat.com>
---
block/parallels.c | 23 ++++++++++-------------
1 file changed, 10 insertions(+), 13 deletions(-)
diff --git a/block/parallels.c b/block/parallels.c
index db6426e5f9..fa8a56a948 100644
--- a/block/parallels.c
+++ b/block/parallels.c
@@ -427,9 +427,8 @@ parallels_co_check(BlockDriverState *bs, BdrvCheckResult
*res,
{
BDRVParallelsState *s = bs->opaque;
int64_t size, prev_off, high_off;
- int ret;
+ int ret = 0;
uint32_t i;
- bool flush_bat = false;
size = bdrv_getlength(bs->file->bs);
if (size < 0) {
@@ -467,9 +466,8 @@ parallels_co_check(BlockDriverState *bs, BdrvCheckResult
*res,
fix & BDRV_FIX_ERRORS ? "Repairing" : "ERROR", i);
res->corruptions++;
if (fix & BDRV_FIX_ERRORS) {
- s->bat_bitmap[i] = 0;
+ parallels_set_bat_entry(s, i, 0);
res->corruptions_fixed++;
- flush_bat = true;
}
prev_off = 0;
continue;
@@ -486,15 +484,6 @@ parallels_co_check(BlockDriverState *bs, BdrvCheckResult
*res,
prev_off = off;
}
- ret = 0;
- if (flush_bat) {
- ret = bdrv_co_pwrite_sync(bs->file, 0, s->header_size, s->header, 0);
- if (ret < 0) {
- res->check_errors++;
- goto out;
- }
- }
-
if (high_off == 0) {
res->image_end_offset = s->data_end << BDRV_SECTOR_BITS;
} else {
@@ -529,6 +518,14 @@ parallels_co_check(BlockDriverState *bs, BdrvCheckResult
*res,
out:
qemu_co_mutex_unlock(&s->lock);
+
+ if (ret == 0) {
+ ret = bdrv_co_flush(bs);
+ if (ret < 0) {
+ res->check_errors++;
+ }
+ }
+
return ret;
}
--
2.40.1
- Re: [PULL 02/17] block: Collapse padded I/O vecs exceeding IOV_MAX, (continued)
[PULL 08/17] parallels: create parallels_set_bat_entry_helper() to assign BAT value, Hanna Czenczek, 2023/06/05
[PULL 06/17] parallels: Fix high_off calculation in parallels_co_check(), Hanna Czenczek, 2023/06/05
[PULL 09/17] parallels: Use generic infrastructure for BAT writing in parallels_co_check(),
Hanna Czenczek <=
[PULL 07/17] parallels: Fix image_end_offset and data_end after out-of-image check, Hanna Czenczek, 2023/06/05
[PULL 14/17] parallels: Move statistic collection to a separate function, Hanna Czenczek, 2023/06/05
[PULL 15/17] parallels: Replace qemu_co_mutex_lock by WITH_QEMU_LOCK_GUARD, Hanna Czenczek, 2023/06/05
[PULL 12/17] parallels: Fix statistics calculation, Hanna Czenczek, 2023/06/05
[PULL 11/17] parallels: Move check of cluster outside image to a separate function, Hanna Czenczek, 2023/06/05
[PULL 17/17] qcow2: add discard-no-unref option, Hanna Czenczek, 2023/06/05
[PULL 16/17] parallels: Incorrect condition in out-of-image check, Hanna Czenczek, 2023/06/05
[PULL 13/17] parallels: Move check of leaks to a separate function, Hanna Czenczek, 2023/06/05
[PULL 10/17] parallels: Move check of unclean image to a separate function, Hanna Czenczek, 2023/06/05
Re: [PULL 00/17] Block patches, Richard Henderson, 2023/06/05