Re: [PULL 05/17] parallels: Out of image offset in BAT leads to image inflation

[Michael Tokarev]

07.06.2023 09:51, Michael Tokarev wrote:
> 05.06.2023 18:45, Hanna Czenczek wrote:
> > From: Alexander Ivanov <alexander.ivanov@virtuozzo.com>
> >
> > data_end field in BDRVParallelsState is set to the biggest offset present
> > in BAT. If this offset is outside of the image, any further write will
> > create the cluster at this offset and/or the image will be truncated to
> > this offset on close. This is definitely not correct.
> >
> > Raise an error in parallels_open() if data_end points outside the image
> > and it is not a check (let the check to repaire the image). Set data_end
> > to the end of the cluster with the last correct offset.
>
> Hi!
>
> This, and a few other parallels changes in this series:
>
>   parallels: Out of image offset in BAT leads to image inflation
>   parallels: Fix high_off calculation in parallels_co_check()
>   parallels: Fix image_end_offset and data_end after out-of-image check
>   parallels: Fix statistics calculation (?)

And probably also:

  parallels: Incorrect condition in out-of-image check

> Should these be applied to -stable too, or is it not important?
>
> Thanks,
>
> /mjt