[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 03/18] target/s390x: Fix LOCFHR taking the wrong half of R2
From: |
Thomas Huth |
Subject: |
[PULL 03/18] target/s390x: Fix LOCFHR taking the wrong half of R2 |
Date: |
Tue, 6 Jun 2023 07:56:06 +0200 |
From: Ilya Leoshkevich <iii@linux.ibm.com>
LOCFHR should write top-to-top, but QEMU erroneously writes
bottom-to-top.
Fixes: 45aa9aa3b773 ("target/s390x: Implement load-on-condition-2 insns")
Cc: qemu-stable@nongnu.org
Reported-by: Mikhail Mitskevich <mitskevichmn@gmail.com>
Closes: https://gitlab.com/qemu-project/qemu/-/issues/1668
Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
Message-Id: <20230526181240.1425579-4-iii@linux.ibm.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: David Hildenbrand <david@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
target/s390x/tcg/insn-data.h.inc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/s390x/tcg/insn-data.h.inc b/target/s390x/tcg/insn-data.h.inc
index e41672684a..937e18ea9d 100644
--- a/target/s390x/tcg/insn-data.h.inc
+++ b/target/s390x/tcg/insn-data.h.inc
@@ -564,7 +564,7 @@
C(0xec46, LOCGHI, RIE_g, LOC2, r1, i2, r1, 0, loc, 0)
C(0xec4e, LOCHHI, RIE_g, LOC2, r1_sr32, i2, new, r1_32h, loc, 0)
/* LOAD HIGH ON CONDITION */
- C(0xb9e0, LOCFHR, RRF_c, LOC2, r1_sr32, r2, new, r1_32h, loc, 0)
+ C(0xb9e0, LOCFHR, RRF_c, LOC2, r1_sr32, r2_sr32, new, r1_32h, loc, 0)
C(0xebe0, LOCFH, RSY_b, LOC2, r1_sr32, m2_32u, new, r1_32h, loc, 0)
/* LOAD PAIR DISJOINT */
D(0xc804, LPD, SSF, ILA, 0, 0, new_P, r3_P32, lpd, 0, MO_TEUL)
--
2.31.1
- [PULL 00/18] s390x and misc patches, Thomas Huth, 2023/06/06
- [PULL 01/18] target/s390x: Fix LCBB overwriting the top 32 bits, Thomas Huth, 2023/06/06
- [PULL 02/18] tests/tcg/s390x: Test LCBB, Thomas Huth, 2023/06/06
- [PULL 03/18] target/s390x: Fix LOCFHR taking the wrong half of R2,
Thomas Huth <=
- [PULL 04/18] tests/tcg/s390x: Test LOCFHR, Thomas Huth, 2023/06/06
- [PULL 05/18] linux-user/s390x: Fix single-stepping SVC, Thomas Huth, 2023/06/06
- [PULL 07/18] Add conditional dependency for libkeyutils, Thomas Huth, 2023/06/06
- [PULL 06/18] tests/tcg/s390x: Test single-stepping SVC, Thomas Huth, 2023/06/06
- [PULL 08/18] target/s390x: Fix MXDB and MXDBR, Thomas Huth, 2023/06/06
- [PULL 10/18] tests/qtest: Run ipmi-bt-test only if CONFIG_IPMI_EXTERN is set, Thomas Huth, 2023/06/06
- [PULL 11/18] gitlab-ci: Remove unused Python package, Thomas Huth, 2023/06/06
- [PULL 09/18] tests/tcg/s390x: Test MXDB and MXDBR, Thomas Huth, 2023/06/06
- [PULL 13/18] scripts: Add qom-cast-macro-clean-cocci-gen.py, Thomas Huth, 2023/06/06
- [PULL 12/18] hw/mips/malta: Fix the malta machine on big endian hosts, Thomas Huth, 2023/06/06