[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 13/18] scripts: Add qom-cast-macro-clean-cocci-gen.py
From: |
Thomas Huth |
Subject: |
[PULL 13/18] scripts: Add qom-cast-macro-clean-cocci-gen.py |
Date: |
Tue, 6 Jun 2023 07:56:16 +0200 |
From: Philippe Mathieu-Daudé <philmd@linaro.org>
Add a script to generate Coccinelle semantic patch
removing all pointless QOM cast macro uses.
Suggested-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-Id: <20230601093452.38972-2-philmd@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
MAINTAINERS | 1 +
scripts/qom-cast-macro-clean-cocci-gen.py | 49 +++++++++++++++++++++++
2 files changed, 50 insertions(+)
create mode 100644 scripts/qom-cast-macro-clean-cocci-gen.py
diff --git a/MAINTAINERS b/MAINTAINERS
index 89f274f85e..b2137111f1 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3045,6 +3045,7 @@ F: include/qom/
F: qapi/qom.json
F: qapi/qdev.json
F: scripts/coccinelle/qom-parent-type.cocci
+F: scripts/qom-cast-macro-clean-cocci-gen.py
F: softmmu/qdev-monitor.c
F: stubs/qdev.c
F: qom/
diff --git a/scripts/qom-cast-macro-clean-cocci-gen.py
b/scripts/qom-cast-macro-clean-cocci-gen.py
new file mode 100644
index 0000000000..2fa8438a14
--- /dev/null
+++ b/scripts/qom-cast-macro-clean-cocci-gen.py
@@ -0,0 +1,49 @@
+#!/usr/bin/env python3
+#
+# Generate a Coccinelle semantic patch to remove pointless QOM cast.
+#
+# Usage:
+#
+# $ qom-cast-macro-clean-cocci-gen.py $(git ls-files) >
qom_pointless_cast.cocci
+# $ spatch \
+# --macro-file scripts/cocci-macro-file.h \
+# --sp-file qom_pointless_cast.cocci \
+# --keep-comments \
+# --use-gitgrep \
+# --in-place \
+# --dir .
+#
+# SPDX-FileContributor: Philippe Mathieu-Daudé <philmd@linaro.org>
+# SPDX-FileCopyrightText: 2023 Linaro Ltd.
+# SPDX-License-Identifier: GPL-2.0-or-later
+
+import re
+import sys
+
+assert len(sys.argv) > 0
+
+def print_cocci_rule(qom_typedef, qom_cast_macro):
+ print(f'''@@
+typedef {qom_typedef};
+{qom_typedef} *obj;
+@@
+- {qom_cast_macro}(obj)
++ obj
+''')
+
+patterns = [
+ r'DECLARE_INSTANCE_CHECKER\((\w+),\W*(\w+),\W*TYPE_\w+\)',
+ r'DECLARE_OBJ_CHECKERS\((\w+),\W*\w+,\W*(\w+),\W*TYPE_\w+\)',
+ r'OBJECT_DECLARE_TYPE\((\w+),\W*\w+,\W*(\w+)\)',
+ r'OBJECT_DECLARE_SIMPLE_TYPE\((\w+),\W*(\w+)\)',
+ r'INTERFACE_CHECK\((\w+),\W*\(\w+\),\W*TYPE_(\w+)\)',
+]
+
+for fn in sys.argv[1:]:
+ try:
+ content = open(fn, 'rt').read()
+ except:
+ continue
+ for pattern in patterns:
+ for match in re.findall(pattern, content):
+ print_cocci_rule(match[0], match[1])
--
2.31.1
- [PULL 02/18] tests/tcg/s390x: Test LCBB, (continued)
- [PULL 02/18] tests/tcg/s390x: Test LCBB, Thomas Huth, 2023/06/06
- [PULL 03/18] target/s390x: Fix LOCFHR taking the wrong half of R2, Thomas Huth, 2023/06/06
- [PULL 04/18] tests/tcg/s390x: Test LOCFHR, Thomas Huth, 2023/06/06
- [PULL 05/18] linux-user/s390x: Fix single-stepping SVC, Thomas Huth, 2023/06/06
- [PULL 07/18] Add conditional dependency for libkeyutils, Thomas Huth, 2023/06/06
- [PULL 06/18] tests/tcg/s390x: Test single-stepping SVC, Thomas Huth, 2023/06/06
- [PULL 08/18] target/s390x: Fix MXDB and MXDBR, Thomas Huth, 2023/06/06
- [PULL 10/18] tests/qtest: Run ipmi-bt-test only if CONFIG_IPMI_EXTERN is set, Thomas Huth, 2023/06/06
- [PULL 11/18] gitlab-ci: Remove unused Python package, Thomas Huth, 2023/06/06
- [PULL 09/18] tests/tcg/s390x: Test MXDB and MXDBR, Thomas Huth, 2023/06/06
- [PULL 13/18] scripts: Add qom-cast-macro-clean-cocci-gen.py,
Thomas Huth <=
- [PULL 12/18] hw/mips/malta: Fix the malta machine on big endian hosts, Thomas Huth, 2023/06/06
- [PULL 14/18] bulk: Remove pointless QOM casts, Thomas Huth, 2023/06/06
- [PULL 15/18] s390x/tcg: Fix CPU address returned by STIDP, Thomas Huth, 2023/06/06
- [PULL 16/18] linux-user/elfload: Expose get_elf_hwcap() on s390x, Thomas Huth, 2023/06/06
- [PULL 18/18] linux-user: Emulate /proc/cpuinfo on s390x, Thomas Huth, 2023/06/06
- [PULL 17/18] linux-user/elfload: Introduce elf_hwcap_str() on s390x, Thomas Huth, 2023/06/06
- Re: [PULL 00/18] s390x and misc patches, Richard Henderson, 2023/06/06