qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PULL 15/18] s390x/tcg: Fix CPU address returned by STIDP


From: Michael Tokarev
Subject: Re: [PULL 15/18] s390x/tcg: Fix CPU address returned by STIDP
Date: Wed, 7 Jun 2023 12:05:41 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0

06.06.2023 08:56, Thomas Huth wrote:
From: Ilya Leoshkevich <iii@linux.ibm.com>

In qemu-user-s390x, /proc/cpuinfo contains:

        processor 0: version = 00,  identification = 000000,  machine = 8561
        processor 1: version = 00,  identification = 400000,  machine = 8561

The highest nibble is supposed to contain the CPU address, but it's off
by 2 bits. Fix the shift value and provide a symbolic constant for it.

With the fix we get:

        processor 0: version = 00,  identification = 000000,  machine = 8561
        processor 1: version = 00,  identification = 100000,  machine = 8561

Fixes: 076d4d39b65f ("s390x/cpumodel: wire up cpu type + id for TCG")
Reviewed-by: David Hildenbrand <david@redhat.com>
Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
Message-Id: <20230605113950.1169228-2-iii@linux.ibm.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
  target/s390x/cpu_models.h | 10 +++++++++-
  target/s390x/cpu_models.c |  4 ++--
  2 files changed, 11 insertions(+), 3 deletions(-)

Is it a -stable material too?
(applies cleanly to 7.2 and 8.0)

Thanks,

/mjt



reply via email to

[Prev in Thread] Current Thread [Next in Thread]