Re: [PULL 15/18] s390x/tcg: Fix CPU address returned by STIDP

[Ilya Leoshkevich]

On Wed, 2023-06-07 at 12:05 +0300, Michael Tokarev wrote:
> 06.06.2023 08:56, Thomas Huth wrote:
> > From: Ilya Leoshkevich <iii@linux.ibm.com>
> > 
> > In qemu-user-s390x, /proc/cpuinfo contains:
> > 
> >         processor 0: version = 00,  identification = 000000, 
> > machine = 8561
> >         processor 1: version = 00,  identification = 400000, 
> > machine = 8561
> > 
> > The highest nibble is supposed to contain the CPU address, but it's
> > off
> > by 2 bits. Fix the shift value and provide a symbolic constant for
> > it.
> > 
> > With the fix we get:
> > 
> >         processor 0: version = 00,  identification = 000000, 
> > machine = 8561
> >         processor 1: version = 00,  identification = 100000, 
> > machine = 8561
> > 
> > Fixes: 076d4d39b65f ("s390x/cpumodel: wire up cpu type + id for
> > TCG")
> > Reviewed-by: David Hildenbrand <david@redhat.com>
> > Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
> > Message-Id: <20230605113950.1169228-2-iii@linux.ibm.com>
> > Signed-off-by: Thomas Huth <thuth@redhat.com>
> > ---
> >   target/s390x/cpu_models.h | 10 +++++++++-
> >   target/s390x/cpu_models.c |  4 ++--
> >   2 files changed, 11 insertions(+), 3 deletions(-)
> 
> Is it a -stable material too?
> (applies cleanly to 7.2 and 8.0)
> 
> Thanks,
> 
> /mjt

Yes, from my perspective, it would be good to put this into stable.
I forgot to tag it, because the rest of the series was a new feature.
Thanks for noticing!