Re: [PATCH] configure: check for $download value properly

[Philippe Mathieu-Daudé]

On 7/6/23 09:50, Michal Privoznik wrote:
> If configure was invoked with --disable-download and git
> submodules were not checked out a warning is produced and the
> configure script fails. But the $download variable (which
> reflects the enable/disable download argument) is checked for in
> a weird fashion:
>
>    test -f "$download" = disabled
>
> Drop the '-f' to check for the actual value of the variable.
>
> Fixes: 2019cabfee0
> Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
> ---
>   configure | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>