Re: [PATCH 1/3] migration/multifd: Rename threadinfo.c functions

[Philippe Mathieu-Daudé]

On 6/6/23 16:45, Fabiano Rosas wrote:
> The code in threadinfo.c is only used for the QMP command
> query-migrationthreads. Make it explicit that this is something
> related to QMP.
>
> The current names are also too generic for a piece of code that
> doesn't affect the migration directly in any way.
>
> Signed-off-by: Fabiano Rosas <farosas@suse.de>
> ---
>   migration/migration.c  | 4 ++--
>   migration/multifd.c    | 4 ++--
>   migration/threadinfo.c | 4 ++--
>   migration/threadinfo.h | 5 ++---
>   4 files changed, 8 insertions(+), 9 deletions(-)


> -MigrationThread *MigrationThreadAdd(const char *name, int thread_id);
> -
> -void MigrationThreadDel(MigrationThread *info);
> +MigrationThread *qmp_migration_threads_add(const char *name, int thread_id);
> +void qmp_migration_threads_remove(MigrationThread *info);

Dropping 'qmp_' prefix:
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>