Re: [PATCH 2/3] migration/multifd: Protect accesses to migration_threads

[Juan Quintela]

Sounds good. 

On Wed, Jun 7, 2023, 18:28 Peter Xu <peterx@redhat.com> wrote:

On Wed, Jun 07, 2023 at 09:00:14AM -0300, Fabiano Rosas wrote:
> >> diff --git a/migration/migration.c b/migration/migration.c
> >> index e731fc98a1..b3b8345eb2 100644
> >> --- a/migration/migration.c
> >> +++ b/migration/migration.c
> >> @@ -1146,6 +1146,7 @@ static void migrate_fd_cleanup(MigrationState *s)
> >>          qemu_mutex_lock_iothread();
> >> 
> >>          multifd_save_cleanup();
> >> +        qmp_migration_threads_cleanup();
> >
> > I think I will spare this one as the mutex is static, so we are not
> > winning any memory back.
> >
>
> Ok

We could consider __attribute__((__constructor__)) in this case.

--
Peter Xu