Re: [PATCH 1/3] migration/multifd: Rename threadinfo.c functions

[Peter Xu]

On Tue, Jun 06, 2023 at 04:34:31PM -0300, Fabiano Rosas wrote:
> Peter Xu <peterx@redhat.com> writes:
> 
> > On Tue, Jun 06, 2023 at 11:45:49AM -0300, Fabiano Rosas wrote:
> >> The code in threadinfo.c is only used for the QMP command
> >> query-migrationthreads. Make it explicit that this is something
> >> related to QMP.
> >> 
> >> The current names are also too generic for a piece of code that
> >> doesn't affect the migration directly in any way.
> >> 
> >> Signed-off-by: Fabiano Rosas <farosas@suse.de>
> >
> > Looks good here, but shall we reserve the qmp_* prefix to mostly qmp stuff
> > only?  Dropping "qmp_" in the new names would look better to me..
> >
> 
> Well, we're just putting the thread name and id on a list so that QMP
> can use them later. It is nothing "important" enough to have a generic
> name like migration_thread.
> 
> Perhaps:
> 
> thread_info_add
> thread_info_remove
> thread_info_init
> thread_info_cleanup
> 
> Anyway, as long as we drop that camel case I'm ok with just removing the
> qmp =)

Thanks.  To me OTOH it's good as long as "qmp_" dropped. :)

I don't worry on using "migration_thread_" as prefix, that's exactly what
the api does to me.  Or, migration_thread_info_*(), migration_thr_mgr_*(),
etc.

-- 
Peter Xu