Re: [PATCH 00/22] target/arm/tcg: Remove inclusions of 'exec/helper-[proto/gen].h'

[Philippe Mathieu-Daudé]

On 9/6/23 12:46, Philippe Mathieu-Daudé wrote:
> Hi,
>
> This series tries to do what Richard suggested in [*]:
>
>    Targets that have a tcg/ subdir should have helper.h.inc
>    moved into there.  At the end, include/exec/helper-gen.h
>    and include/exec/helper-proto.h become unused and go away.
>
> but only for the ARM target, to first see if this is heading
> in the correct direction.
>
> Instead of having TCG generated helpers included by all
> translate/helper units, they are reduced to the few places
> really needing them. I expect the build step to be slighly
> improved, since the compiler doesn't have to compile and
> track unused helpers definitions.


>   42 files changed, 2100 insertions(+), 1804 deletions(-)
>   create mode 100644 target/arm/tcg/helper-iwmmxt.h.inc
>   create mode 100644 target/arm/tcg/helper-neon.h.inc
>   create mode 100644 target/arm/tcg/helper-vfp.h.inc
>   create mode 100644 target/arm/tcg/translate-iwmmxt.c

Note to myself, these new files miss a license.

Perhaps we could have a check for SPDX in checkpatch.pl, along with
"added, moved or deleted file(s), does MAINTAINERS need updating?".