qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 03/15] hw/pci-host/q35: Initialize PCMachineState::bus in boa


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH 03/15] hw/pci-host/q35: Initialize PCMachineState::bus in board code
Date: Mon, 12 Jun 2023 12:28:12 +0200
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.11.2

On 11/6/23 12:34, Bernhard Beschow wrote:
The Q35 PCI host currently sets the PC machine's PCI bus attribute
through global state, thereby assuming the machine to be a PC machine.
The Q35 machine code already holds on to Q35's pci bus attribute, so can
easily set its own property while preserving encapsulation.

Signed-off-by: Bernhard Beschow <shentey@gmail.com>
---
  hw/i386/pc_q35.c  | 4 +++-
  hw/pci-host/q35.c | 1 -
  2 files changed, 3 insertions(+), 2 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]