[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 05/15] hw/pci-host/q35: Initialize PCI_HOST_BYPASS_IOMMU prop
From: |
Igor Mammedov |
Subject: |
Re: [PATCH 05/15] hw/pci-host/q35: Initialize PCI_HOST_BYPASS_IOMMU property from board code |
Date: |
Mon, 12 Jun 2023 15:51:24 +0200 |
On Sun, 11 Jun 2023 12:34:02 +0200
Bernhard Beschow <shentey@gmail.com> wrote:
> The Q35 PCI host already has a PCI_HOST_BYPASS_IOMMU property. However, the
> host initializes this property itself by accessing global machine state,
> thereby assuming it to be a PC machine. Avoid this by having board code
> set this property.
>
> Signed-off-by: Bernhard Beschow <shentey@gmail.com>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
> ---
> hw/i386/pc_q35.c | 2 ++
> hw/pci-host/q35.c | 3 +--
> 2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c
> index 29b46d3e1c..5220b535b2 100644
> --- a/hw/i386/pc_q35.c
> +++ b/hw/i386/pc_q35.c
> @@ -230,6 +230,8 @@ static void pc_q35_init(MachineState *machine)
> x86ms->below_4g_mem_size, NULL);
> object_property_set_int(phb, PCI_HOST_ABOVE_4G_MEM_SIZE,
> x86ms->above_4g_mem_size, NULL);
> + object_property_set_bool(phb, PCI_HOST_BYPASS_IOMMU,
> + pcms->default_bus_bypass_iommu, NULL);
> sysbus_realize_and_unref(SYS_BUS_DEVICE(phb), &error_fatal);
>
> /* pci */
> diff --git a/hw/pci-host/q35.c b/hw/pci-host/q35.c
> index 23b689dba3..7980ddde69 100644
> --- a/hw/pci-host/q35.c
> +++ b/hw/pci-host/q35.c
> @@ -66,8 +66,7 @@ static void q35_host_realize(DeviceState *dev, Error **errp)
> s->mch.pci_address_space,
> s->mch.address_space_io,
> 0, TYPE_PCIE_BUS);
> - pci->bypass_iommu =
> - PC_MACHINE(qdev_get_machine())->default_bus_bypass_iommu;
> +
> qdev_realize(DEVICE(&s->mch), BUS(pci->bus), &error_fatal);
> }
>
- Re: [PATCH 03/15] hw/pci-host/q35: Initialize PCMachineState::bus in board code, (continued)
- [PATCH 04/15] hw/pci/pci_host: Introduce PCI_HOST_BYPASS_IOMMU macro, Bernhard Beschow, 2023/06/11
- [PATCH 06/15] hw/pci-host/q35: Make some property name macros reusable by i440fx, Bernhard Beschow, 2023/06/11
- [PATCH 07/15] hw/pci-host/i440fx: Replace magic values by existing constants, Bernhard Beschow, 2023/06/11
- [PATCH 05/15] hw/pci-host/q35: Initialize PCI_HOST_BYPASS_IOMMU property from board code, Bernhard Beschow, 2023/06/11
- [PATCH 08/15] hw/pci-host/i440fx: Have common names for some local variables, Bernhard Beschow, 2023/06/11
- [PATCH 10/15] hw/pci-host/i440fx: Make MemoryRegion pointers accessible as properties, Bernhard Beschow, 2023/06/11
- [PATCH 09/15] hw/pci-host/i440fx: Move i440fx_realize() into PCII440FXState section, Bernhard Beschow, 2023/06/11
- [PATCH 11/15] hw/pci-host/i440fx: Add PCI_HOST_PROP_IO_MEM property, Bernhard Beschow, 2023/06/11
- [PATCH 15/15] hw/i386/pc_piix: Move i440fx' realize near its qdev_new(), Bernhard Beschow, 2023/06/11