[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 11/15] hw/pci-host/i440fx: Add PCI_HOST_PROP_IO_MEM property
From: |
Bernhard Beschow |
Subject: |
Re: [PATCH 11/15] hw/pci-host/i440fx: Add PCI_HOST_PROP_IO_MEM property |
Date: |
Mon, 12 Jun 2023 17:54:08 +0000 |
Am 12. Juni 2023 10:31:48 UTC schrieb "Philippe Mathieu-Daudé"
<philmd@linaro.org>:
>On 11/6/23 12:34, Bernhard Beschow wrote:
>> Introduce the property in anticipation of QOM'ification; Q35 has the same
>> property.
>>
>> Signed-off-by: Bernhard Beschow <shentey@gmail.com>
>> ---
>> hw/pci-host/i440fx.c | 14 ++++++++++----
>> 1 file changed, 10 insertions(+), 4 deletions(-)
>
>
>> @@ -51,6 +50,7 @@ struct I440FXState {
>> /*< public >*/
>> MemoryRegion *system_memory;
>> + MemoryRegion *address_space_io;
>
>"io_mem" like the property? (this is not an AddressSpace)
Agreed. I'd name it "io_memory" to be consistent with above attribute.
Best regards,
Bernhard
>
>> MemoryRegion *pci_address_space;
>
>(pre-existing misleading name)
>
>> MemoryRegion *ram_memory;
>> Range pci_hole;
>
- Re: [PATCH 05/15] hw/pci-host/q35: Initialize PCI_HOST_BYPASS_IOMMU property from board code, (continued)
- [PATCH 08/15] hw/pci-host/i440fx: Have common names for some local variables, Bernhard Beschow, 2023/06/11
- [PATCH 10/15] hw/pci-host/i440fx: Make MemoryRegion pointers accessible as properties, Bernhard Beschow, 2023/06/11
- [PATCH 09/15] hw/pci-host/i440fx: Move i440fx_realize() into PCII440FXState section, Bernhard Beschow, 2023/06/11
- [PATCH 11/15] hw/pci-host/i440fx: Add PCI_HOST_PROP_IO_MEM property, Bernhard Beschow, 2023/06/11
- [PATCH 15/15] hw/i386/pc_piix: Move i440fx' realize near its qdev_new(), Bernhard Beschow, 2023/06/11
[PATCH 12/15] hw/pci-host/i440fx: Add PCI_HOST_{ABOVE, BELOW}_4G_MEM_SIZE properties, Bernhard Beschow, 2023/06/11
[PATCH 14/15] hw/pci-host/i440fx: Resolve i440fx_init(), Bernhard Beschow, 2023/06/11
[PATCH 13/15] hw/pci-host/i440fx: Add I440FX_HOST_PROP_PCI_TYPE property, Bernhard Beschow, 2023/06/11