Re: [PATCH 01/42] migration-test: Be consistent for ppc

[Laurent Vivier]

On 6/20/23 16:54, Peter Xu wrote:
> On Fri, Jun 09, 2023 at 12:49:02AM +0200, Juan Quintela wrote:
> > It makes no sense that we don't have the same configuration on both sides.
>
> I hope Laurent can see this one out of 40s.

I had some luck...

> Makes sense to me, but does it mean that the devices are not matching
> before on ppc?  Confused how did it work then..

I agree we need the -nodefaults on both sides.

It has been introduced by
fc71e3e562b7 ("tests/migration: Speed up the test on ppc64") (Thomas)

I think it works because destination side doesn't check for what is missing.

Reviewed-by: Laurent Vivier <lvivier@redhat.com>

Thanks,
Laurent
> > Signed-off-by: Juan Quintela <quintela@redhat.com>
> > ---
> >   tests/qtest/migration-test.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c
> > index b0c355bbd9..c5e0c69c6b 100644
> > --- a/tests/qtest/migration-test.c
> > +++ b/tests/qtest/migration-test.c
> > @@ -646,7 +646,7 @@ static int test_migrate_start(QTestState **from, QTestState 
> > **to,
> >                                         "'nvramrc=hex .\" _\" begin %x %x "
> >                                         "do i c@ 1 + i c! 1000 +loop .\" B\" 0 "
> >                                         "until'", end_address, start_address);
> > -        arch_target = g_strdup("");
> > +        arch_target = g_strdup("-nodefaults");
> >       } else if (strcmp(arch, "aarch64") == 0) {
> >           init_bootfile(bootpath, aarch64_kernel, sizeof(aarch64_kernel));
> >           machine_opts = "virt,gic-version=max";
> > --
> > 2.40.1