[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 01/42] migration-test: Be consistent for ppc
From: |
Peter Xu |
Subject: |
Re: [PATCH 01/42] migration-test: Be consistent for ppc |
Date: |
Tue, 20 Jun 2023 15:42:29 -0400 |
On Tue, Jun 20, 2023 at 09:27:17PM +0200, Laurent Vivier wrote:
> On 6/20/23 16:54, Peter Xu wrote:
> > On Fri, Jun 09, 2023 at 12:49:02AM +0200, Juan Quintela wrote:
> > > It makes no sense that we don't have the same configuration on both sides.
> >
> > I hope Laurent can see this one out of 40s.
>
> I had some luck...
:-D
>
> >
> > Makes sense to me, but does it mean that the devices are not matching
> > before on ppc? Confused how did it work then..
>
> I agree we need the -nodefaults on both sides.
>
> It has been introduced by
> fc71e3e562b7 ("tests/migration: Speed up the test on ppc64") (Thomas)
>
> I think it works because destination side doesn't check for what is missing.
Oh! Makes sense.. just notice this (fact). Then no fixes needed either.
>
> Reviewed-by: Laurent Vivier <lvivier@redhat.com>
Thanks, Laurent!
--
Peter Xu
[PATCH 04/42] migration-test: Make machine_opts regular with other options, Juan Quintela, 2023/06/08
[PATCH 05/42] migration-test: Create arch_opts, Juan Quintela, 2023/06/08