Re: [RFC PATCH-for-8.1] accel: Remove HAX accelerator

[Philippe Mathieu-Daudé]

On 24/6/23 01:08, Philippe Mathieu-Daudé wrote:
> HAX is deprecated since commits 73741fda6c ("MAINTAINERS: Abort
> HAXM maintenance") and 90c167a1da ("docs/about/deprecated: Mark
> HAXM in QEMU as deprecated"), released in v8.0.0.
>
> Per the QEMU deprecation policy, we shouldn't remove it before
> QEMU release v8.2.0. However per the latest HAXM release (v7.8),
> the latest QEMU supported is v7.2:
>
>    Note: Up to this release, HAXM supports QEMU from 2.9.0 to 7.2.0.
>
> (https://github.com/intel/haxm/releases/tag/v7.8.0)
>
> The next commit (https://github.com/intel/haxm/commit/da1b8ec072)
> added:
>
>    HAXM v7.8.0 is our last release and we will not accept
>    pull requests or respond to issues after this.
>
> As of commit b455ce4c2f, it became very hard to build and test
> HAXM. Its previous maintainers made it clear they won't help.
> It doesn't seem to be a very good use of QEMU maintainers to
> spend their time in a dead project. Save our time by removing
> this orphan zombie code before the QEMU v8.2 release.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---


> diff --git a/docs/about/removed-features.rst b/docs/about/removed-features.rst
> index 5b258b446b..cc8a1e38a9 100644
> --- a/docs/about/removed-features.rst
> +++ b/docs/about/removed-features.rst
> @@ -659,15 +659,18 @@ Use ``Icelake-Server`` instead.
>   System accelerators
>   -------------------
>   
> -Userspace local APIC with KVM (x86, removed 8.0)
> +Userspace local APIC with KVM (x86, removed in 8.0)
>   ''''''''''''''''''''''''''''''''''''''''''''''''

Oops I didn't mean to commit this line. The doc won't build with padding.

>   ``-M kernel-irqchip=off`` cannot be used on KVM if the CPU model includes
>   a local APIC.  The ``split`` setting is supported, as is using ``-M
>   kernel-irqchip=off`` when the CPU does not have a local APIC.