qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC PATCH-for-8.1] accel: Remove HAX accelerator


From: Richard Henderson
Subject: Re: [RFC PATCH-for-8.1] accel: Remove HAX accelerator
Date: Mon, 26 Jun 2023 10:33:43 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0

On 6/24/23 01:08, Philippe Mathieu-Daudé wrote:
HAX is deprecated since commits 73741fda6c ("MAINTAINERS: Abort
HAXM maintenance") and 90c167a1da ("docs/about/deprecated: Mark
HAXM in QEMU as deprecated"), released in v8.0.0.

Per the QEMU deprecation policy, we shouldn't remove it before
QEMU release v8.2.0. However per the latest HAXM release (v7.8),
the latest QEMU supported is v7.2:

   Note: Up to this release, HAXM supports QEMU from 2.9.0 to 7.2.0.

(https://github.com/intel/haxm/releases/tag/v7.8.0)

The next commit (https://github.com/intel/haxm/commit/da1b8ec072)
added:

   HAXM v7.8.0 is our last release and we will not accept
   pull requests or respond to issues after this.

As of commit b455ce4c2f, it became very hard to build and test
HAXM. Its previous maintainers made it clear they won't help.
It doesn't seem to be a very good use of QEMU maintainers to
spend their time in a dead project. Save our time by removing
this orphan zombie code before the QEMU v8.2 release.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
  MAINTAINERS                                   |    8 -
  docs/about/build-platforms.rst                |    2 +-
  docs/about/deprecated.rst                     |    6 -
  docs/about/removed-features.rst               |    9 +-
  docs/system/introduction.rst                  |    3 -
  meson.build                                   |    7 -
  include/exec/poison.h                         |    1 -
  include/hw/core/cpu.h                         |    2 +-
  include/sysemu/hax.h                          |   49 -
  include/sysemu/hw_accel.h                     |    1 -
  target/i386/hax/hax-accel-ops.h               |   31 -
  target/i386/hax/hax-i386.h                    |   98 --
  target/i386/hax/hax-interface.h               |  369 ------
  target/i386/hax/hax-posix.h                   |   61 -
  target/i386/hax/hax-windows.h                 |   88 --
  accel/stubs/hax-stub.c                        |   24 -
  hw/intc/apic_common.c                         |    3 +-
  softmmu/cpus.c                                |    6 -
  softmmu/vl.c                                  |    6 -
  target/i386/hax/hax-accel-ops.c               |  105 --
  target/i386/hax/hax-all.c                     | 1141 -----------------
  target/i386/hax/hax-mem.c                     |  323 -----
  target/i386/hax/hax-posix.c                   |  305 -----
  target/i386/hax/hax-windows.c                 |  485 -------
  accel/stubs/meson.build                       |    1 -
  meson_options.txt                             |    2 -
  qemu-options.hx                               |    8 +-
  .../ci/org.centos/stream/8/x86_64/configure   |    1 -
  scripts/meson-buildoptions.sh                 |    3 -
  target/i386/hax/meson.build                   |    7 -
  target/i386/meson.build                       |    1 -
  31 files changed, 13 insertions(+), 3143 deletions(-)
  delete mode 100644 include/sysemu/hax.h
  delete mode 100644 target/i386/hax/hax-accel-ops.h
  delete mode 100644 target/i386/hax/hax-i386.h
  delete mode 100644 target/i386/hax/hax-interface.h
  delete mode 100644 target/i386/hax/hax-posix.h
  delete mode 100644 target/i386/hax/hax-windows.h
  delete mode 100644 accel/stubs/hax-stub.c
  delete mode 100644 target/i386/hax/hax-accel-ops.c
  delete mode 100644 target/i386/hax/hax-all.c
  delete mode 100644 target/i386/hax/hax-mem.c
  delete mode 100644 target/i386/hax/hax-posix.c
  delete mode 100644 target/i386/hax/hax-windows.c
  delete mode 100644 target/i386/hax/meson.build


Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]