qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/3] tests/acpi/bios-tables-test: use the correct slot on the


From: Igor Mammedov
Subject: Re: [PATCH 2/3] tests/acpi/bios-tables-test: use the correct slot on the pcie-root-port
Date: Mon, 26 Jun 2023 13:02:11 +0200

On Wed, 21 Jun 2023 19:37:22 +0530
Ani Sinha <anisinha@redhat.com> wrote:

> PCIE ports only have one slot, slot 0. Hence, non-zero slots are not available
> for PCIE devices on PCIE root ports. Fix test_acpi_q35_tcg_no_acpi_hotplug()
> so that the test does not use them.
> 
> Signed-off-by: Ani Sinha <anisinha@redhat.com>

Reviewed-by: Igor Mammedov <imammedo@redhat.com>

> ---
>  tests/qtest/bios-tables-test.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c
> index ed1c69cf01..47ba20b957 100644
> --- a/tests/qtest/bios-tables-test.c
> +++ b/tests/qtest/bios-tables-test.c
> @@ -1020,9 +1020,9 @@ static void test_acpi_q35_tcg_no_acpi_hotplug(void)
>          " -device pci-testdev,bus=nohprp,acpi-index=501"
>          " -device 
> pcie-root-port,id=nohprpint,port=0x0,chassis=3,hotplug=off,"
>                                   "multifunction=on,addr=8.0"
> -        " -device pci-testdev,bus=nohprpint,acpi-index=601,addr=8.1"
> +        " -device pci-testdev,bus=nohprpint,acpi-index=601,addr=0.1"
>          " -device pcie-root-port,id=hprp2,port=0x0,chassis=4,bus=nohprpint,"
> -                                 "addr=9.0"
> +                                 "addr=0.2"
>          " -device pci-testdev,bus=hprp2,acpi-index=602"
>          , &data);
>      free_test_data(&data);




reply via email to

[Prev in Thread] Current Thread [Next in Thread]