Re: [PATCH 3/3] tests/acpi/bios-tables-test: update acpi blob q35/DSDT.noacpihp

[Igor Mammedov]

On Wed, 21 Jun 2023 19:37:23 +0530
Ani Sinha <anisinha@redhat.com> wrote:

> Some fixes were committed in bios-tables-test in the previous commit. Update
> the acpi blob and clear bios-tables-test-allowed-diff.h so that the test
> continues to pass with the changes in the bios-tables-test.
> 
> Following is the asl diff between the old and the newly updated blob:
> 
> @@ -1,30 +1,30 @@
>  /*
>   * Intel ACPI Component Architecture
>   * AML/ASL+ Disassembler version 20210604 (64-bit version)
>   * Copyright (c) 2000 - 2021 Intel Corporation
>   *
>   * Disassembling to symbolic ASL+ operators
>   *
> - * Disassembly of tests/data/acpi/q35/DSDT.noacpihp, Wed Jun 21 18:26:52 2023
> + * Disassembly of /tmp/aml-O8SU61, Wed Jun 21 18:26:52 2023
>   *
>   * Original Table Header:
>   *     Signature        "DSDT"
> - *     Length           0x00002038 (8248)
> + *     Length           0x00002031 (8241)
>   *     Revision         0x01 **** 32-bit table (V1), no 64-bit math support
> - *     Checksum         0x4A
> + *     Checksum         0x89
>   *     OEM ID           "BOCHS "
>   *     OEM Table ID     "BXPC    "
>   *     OEM Revision     0x00000001 (1)
>   *     Compiler ID      "BXPC"
>   *     Compiler Version 0x00000001 (1)
>   */
>  DefinitionBlock ("", "DSDT", 1, "BOCHS ", "BXPC    ", 0x00000001)
>  {
>      Scope (\)
>      {
>          OperationRegion (DBG, SystemIO, 0x0402, One)
>          Field (DBG, ByteAcc, NoLock, Preserve)
>          {
>              DBGB,   8
>          }
> 
> @@ -3148,48 +3148,48 @@
>                  {
>                      Name (_ADR, Zero)  // _ADR: Address
>                      Method (_DSM, 4, Serialized)  // _DSM: Device-Specific 
> Method
>                      {
>                          Local0 = Package (0x01)
>                              {
>                                  0x01F5
>                              }
>                          Return (EDSM (Arg0, Arg1, Arg2, Arg3, Local0))
>                      }
>                  }
>              }
> 
>              Device (S40)
>              {
>                  Name (_ADR, 0x00080000)  // _ADR: Address
> -                Device (S41)
> +                Device (S01)
>                  {
> -                    Name (_ADR, 0x00080001)  // _ADR: Address
> +                    Name (_ADR, One)  // _ADR: Address
>                      Method (_DSM, 4, Serialized)  // _DSM: Device-Specific 
> Method
>                      {
>                          Local0 = Package (0x01)
>                              {
>                                  0x0259
>                              }
>                          Return (EDSM (Arg0, Arg1, Arg2, Arg3, Local0))
>                      }
>                  }
> 
> -                Device (S48)
> +                Device (S02)
>                  {
> -                    Name (_ADR, 0x00090000)  // _ADR: Address
> +                    Name (_ADR, 0x02)  // _ADR: Address
>                      Device (S00)
>                      {
>                          Name (_ADR, Zero)  // _ADR: Address
>                      }
>                  }
>              }
> 
>              Device (SF8)
>              {
>                  Name (_ADR, 0x001F0000)  // _ADR: Address
>                  OperationRegion (PIRQ, PCI_Config, 0x60, 0x0C)
>                  Scope (\_SB)
>                  {
>                      Field (PCI0.SF8.PIRQ, ByteAcc, NoLock, Preserve)
>                      {
>                          PRQA,   8,
> 
> Signed-off-by: Ani Sinha <anisinha@redhat.com>

Acked-by: Igor Mammedov <imammedo@redhat.com>

> ---
>  tests/data/acpi/q35/DSDT.noacpihp           | Bin 8248 -> 8241 bytes
>  tests/qtest/bios-tables-test-allowed-diff.h |   1 -
>  2 files changed, 1 deletion(-)
> 
> diff --git a/tests/data/acpi/q35/DSDT.noacpihp 
> b/tests/data/acpi/q35/DSDT.noacpihp
> index 
> 6ab1f0e52543fcb7f84a7fd1327fe5aa42010565..8cab2f8eb9ae94e0165f3f17857ec7d080fb0e13
>  100644
> GIT binary patch
> delta 109
> zcmdntu+f3bCD<jzP=SGgv2!Dri!7J3UQB$jQ@nt;?&b(tDMlAZ)?gEZc#e2SmmnSn
> z1`dYkCY4|VLx=#Qh(x?gurE)65Gx~hBvZl?S0FDVGb=kGx=AwFzzCv>i)r&-xoSoL  
> DyqFtK
> 
> delta 94
> zcmdn!u)~4NCD<jzLV<yS(Q6}@i!7IyUQB$jQ@nta-sT8dDMm#P)?gEZc#e2SmmnSn
> k1`dYkCXHYdL#O~FP+)SuoHV~ou!#j+5huguZF1F&02bsG6#xJL
> 
> diff --git a/tests/qtest/bios-tables-test-allowed-diff.h 
> b/tests/qtest/bios-tables-test-allowed-diff.h
> index 31df9c6187..dfb8523c8b 100644
> --- a/tests/qtest/bios-tables-test-allowed-diff.h
> +++ b/tests/qtest/bios-tables-test-allowed-diff.h
> @@ -1,2 +1 @@
>  /* List of comma-separated changed AML files to ignore */
> -"tests/data/acpi/q35/DSDT.noacpihp",