[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 13/18] target/i386: Intel only supports SYSCALL/SYSRET in long mod
From: |
Paolo Bonzini |
Subject: |
[PULL 13/18] target/i386: Intel only supports SYSCALL/SYSRET in long mode |
Date: |
Mon, 26 Jun 2023 13:14:40 +0200 |
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
target/i386/cpu.c | 4 ++++
target/i386/tcg/translate.c | 9 ++++++++-
2 files changed, 12 insertions(+), 1 deletion(-)
diff --git a/target/i386/cpu.c b/target/i386/cpu.c
index 695e01582bf..978d24b5ec7 100644
--- a/target/i386/cpu.c
+++ b/target/i386/cpu.c
@@ -6238,6 +6238,10 @@ void cpu_x86_cpuid(CPUX86State *env, uint32_t index,
uint32_t count,
*ecx |= 1 << 1; /* CmpLegacy bit */
}
}
+ if (tcg_enabled() && env->cpuid_vendor1 == CPUID_VENDOR_INTEL_1 &&
+ !(env->hflags & HF_LMA_MASK)) {
+ *edx &= ~CPUID_EXT2_SYSCALL;
+ }
break;
case 0x80000002:
case 0x80000003:
diff --git a/target/i386/tcg/translate.c b/target/i386/tcg/translate.c
index b2e2dccb84f..ed4016f554b 100644
--- a/target/i386/tcg/translate.c
+++ b/target/i386/tcg/translate.c
@@ -5692,7 +5692,10 @@ static bool disas_insn(DisasContext *s, CPUState *cpu)
break;
#ifdef TARGET_X86_64
case 0x105: /* syscall */
- /* XXX: is it usable in real mode ? */
+ /* For Intel SYSCALL is only valid in long mode */
+ if (!LMA(s) && env->cpuid_vendor1 == CPUID_VENDOR_INTEL_1) {
+ goto illegal_op;
+ }
gen_update_cc_op(s);
gen_update_eip_cur(s);
gen_helper_syscall(cpu_env, cur_insn_len_i32(s));
@@ -5702,6 +5705,10 @@ static bool disas_insn(DisasContext *s, CPUState *cpu)
gen_eob_worker(s, false, true);
break;
case 0x107: /* sysret */
+ /* For Intel SYSRET is only valid in long mode */
+ if (!LMA(s) && env->cpuid_vendor1 == CPUID_VENDOR_INTEL_1) {
+ goto illegal_op;
+ }
if (!PE(s)) {
gen_exception_gpf(s);
} else {
--
2.41.0
- [PULL 04/18] hw/arm: Validate cluster and NUMA node boundary, (continued)
- [PULL 04/18] hw/arm: Validate cluster and NUMA node boundary, Paolo Bonzini, 2023/06/26
- [PULL 01/18] build: further refine build.ninja rules, Paolo Bonzini, 2023/06/26
- [PULL 02/18] hw/remote/proxy: Remove dubious 'event_notifier-posix.c' include, Paolo Bonzini, 2023/06/26
- [PULL 06/18] kvm: reuse per-vcpu stats fd to avoid vcpu interruption, Paolo Bonzini, 2023/06/26
- [PULL 05/18] hw/riscv: Validate cluster and NUMA node boundary, Paolo Bonzini, 2023/06/26
- [PULL 07/18] target/i386: fix INVD vmexit, Paolo Bonzini, 2023/06/26
- [PULL 08/18] target/i386: TCG supports 3DNow! prefetch(w), Paolo Bonzini, 2023/06/26
- [PULL 09/18] target/i386: TCG supports RDSEED, Paolo Bonzini, 2023/06/26
- [PULL 10/18] target/i386: do not accept RDSEED if CPUID bit absent, Paolo Bonzini, 2023/06/26
- [PULL 11/18] target/i386: TCG supports XSAVEERPTR, Paolo Bonzini, 2023/06/26
- [PULL 13/18] target/i386: Intel only supports SYSCALL/SYSRET in long mode,
Paolo Bonzini <=
- [PULL 12/18] target/i386: TCG supports WBNOINVD, Paolo Bonzini, 2023/06/26
- [PULL 16/18] target/i386: implement RDPID in TCG, Paolo Bonzini, 2023/06/26
- [PULL 14/18] target/i386: AMD only supports SYSENTER/SYSEXIT in 32-bit mode, Paolo Bonzini, 2023/06/26
- [PULL 15/18] target/i386: sysret and sysexit are privileged, Paolo Bonzini, 2023/06/26
- [PULL 17/18] target/i386: implement SYSCALL/SYSRET in 32-bit emulators, Paolo Bonzini, 2023/06/26
- [PULL 18/18] git-submodule.sh: allow running in validate mode without previous update, Paolo Bonzini, 2023/06/26
- Re: [PULL 00/18] Misc, i386 patches for 2023-06-26, Richard Henderson, 2023/06/26