Re: [PATCH qemu v4 2/2] tests/tcg/aarch64: Add testcases for IC IVAU and dual-mapped code

[Peter Maydell]

On Mon, 26 Jun 2023 at 15:15, ~jhogberg <jhogberg@git.sr.ht> wrote:
>
> From: John Högberg <john.hogberg@ericsson.com>
>
> https://gitlab.com/qemu-project/qemu/-/issues/1034
>
> Signed-off-by: John Högberg <john.hogberg@ericsson.com>


> +static int self_modification_test(uint32_t *rw_data, const uint32_t 
> *exec_data)
> +{
> +    /*
> +     * This test is self-modifying in an attempt to cover an edge case where
> +     * the IC IVAU instruction invalidates itself.
> +     *
> +     * Note that the IC IVAU instruction is 16 bytes into the function, in 
> what
> +     * will be the same cache line as the modifed instruction on machines 
> with

typo: "modified".

Otherwise
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

thanks
-- PMM