[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 2/7] hw/nvme: consider COPY command in nvme_aio_err
From: |
Klaus Jensen |
Subject: |
[PULL 2/7] hw/nvme: consider COPY command in nvme_aio_err |
Date: |
Wed, 28 Jun 2023 11:24:56 +0200 |
From: Minwoo Im <minwoo.im@samsung.com>
If we don't have NVME_CMD_COPY consideration in the switch statement in
nvme_aio_err(), it will go to have NVME_INTERNAL_DEV_ERROR and
`req->status` will be ovewritten to it. During the aio context, it
might set the NVMe status field like NVME_CMD_SIZE_LIMIT, but it's
overwritten in the nvme_aio_err().
Add consideration for the NVME_CMD_COPY not to overwrite the status at
the end of the function.
Signed-off-by: Minwoo Im <minwoo.im@samsung.com>
Reviewed-by: Klaus Jensen <k.jensen@samsung.com>
Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
---
hw/nvme/ctrl.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl.c
index 020f37a780e0..e031c2250a84 100644
--- a/hw/nvme/ctrl.c
+++ b/hw/nvme/ctrl.c
@@ -1755,6 +1755,7 @@ static void nvme_aio_err(NvmeRequest *req, int ret)
case NVME_CMD_WRITE:
case NVME_CMD_WRITE_ZEROES:
case NVME_CMD_ZONE_APPEND:
+ case NVME_CMD_COPY:
status = NVME_WRITE_FAULT;
break;
default:
--
2.41.0
- [PULL 0/7] hw/nvme updates, Klaus Jensen, 2023/06/28
- [PULL 2/7] hw/nvme: consider COPY command in nvme_aio_err,
Klaus Jensen <=
- [PULL 1/7] hw/nvme: add comment for nvme-ns properties, Klaus Jensen, 2023/06/28
- [PULL 3/7] hw/nvme: check maximum copy length (MCL) for COPY, Klaus Jensen, 2023/06/28
- [PULL 4/7] hw/nvme: fix verification of number of ruhis, Klaus Jensen, 2023/06/28
- [PULL 5/7] hw/nvme: verify uniqueness of reclaim unit handle identifiers, Klaus Jensen, 2023/06/28
- [PULL 6/7] hw/nvme: add placement handle list ranges, Klaus Jensen, 2023/06/28
- [PULL 7/7] docs: update hw/nvme documentation for TP4146, Klaus Jensen, 2023/06/28
- Re: [PULL 0/7] hw/nvme updates, Richard Henderson, 2023/06/28