[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 3/7] hw/nvme: check maximum copy length (MCL) for COPY
From: |
Klaus Jensen |
Subject: |
[PULL 3/7] hw/nvme: check maximum copy length (MCL) for COPY |
Date: |
Wed, 28 Jun 2023 11:24:57 +0200 |
From: Minwoo Im <minwoo.im@samsung.com>
MCL(Maximum Copy Length) in the Identify Namespace data structure limits
the number of LBAs to be copied inside of the controller. We've not
checked it at all, so added the check with returning the proper error
status.
Signed-off-by: Minwoo Im <minwoo.im@samsung.com>
Reviewed-by: Klaus Jensen <k.jensen@samsung.com>
Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
---
hw/nvme/ctrl.c | 24 ++++++++++++++++++++++++
1 file changed, 24 insertions(+)
diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl.c
index e031c2250a84..355668bdf87e 100644
--- a/hw/nvme/ctrl.c
+++ b/hw/nvme/ctrl.c
@@ -2855,6 +2855,25 @@ static void nvme_copy_source_range_parse(void *ranges,
int idx, uint8_t format,
}
}
+static inline uint16_t nvme_check_copy_mcl(NvmeNamespace *ns,
+ NvmeCopyAIOCB *iocb, uint16_t nr)
+{
+ uint32_t copy_len = 0;
+
+ for (int idx = 0; idx < nr; idx++) {
+ uint32_t nlb;
+ nvme_copy_source_range_parse(iocb->ranges, idx, iocb->format, NULL,
+ &nlb, NULL, NULL, NULL);
+ copy_len += nlb + 1;
+ }
+
+ if (copy_len > ns->id_ns.mcl) {
+ return NVME_CMD_SIZE_LIMIT | NVME_DNR;
+ }
+
+ return NVME_SUCCESS;
+}
+
static void nvme_copy_out_completed_cb(void *opaque, int ret)
{
NvmeCopyAIOCB *iocb = opaque;
@@ -3167,6 +3186,11 @@ static uint16_t nvme_copy(NvmeCtrl *n, NvmeRequest *req)
}
}
+ status = nvme_check_copy_mcl(ns, iocb, nr);
+ if (status) {
+ goto invalid;
+ }
+
iocb->req = req;
iocb->ret = 0;
iocb->nr = nr;
--
2.41.0
- [PULL 0/7] hw/nvme updates, Klaus Jensen, 2023/06/28
- [PULL 2/7] hw/nvme: consider COPY command in nvme_aio_err, Klaus Jensen, 2023/06/28
- [PULL 1/7] hw/nvme: add comment for nvme-ns properties, Klaus Jensen, 2023/06/28
- [PULL 3/7] hw/nvme: check maximum copy length (MCL) for COPY,
Klaus Jensen <=
- [PULL 4/7] hw/nvme: fix verification of number of ruhis, Klaus Jensen, 2023/06/28
- [PULL 5/7] hw/nvme: verify uniqueness of reclaim unit handle identifiers, Klaus Jensen, 2023/06/28
- [PULL 6/7] hw/nvme: add placement handle list ranges, Klaus Jensen, 2023/06/28
- [PULL 7/7] docs: update hw/nvme documentation for TP4146, Klaus Jensen, 2023/06/28
- Re: [PULL 0/7] hw/nvme updates, Richard Henderson, 2023/06/28