qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/2] target/riscv: Remove redundant check in pmp_is_locked


From: Weiwei Li
Subject: Re: [PATCH 1/2] target/riscv: Remove redundant check in pmp_is_locked
Date: Wed, 28 Jun 2023 21:21:02 +0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0


On 2023/6/28 18:36, Ruibo Lu wrote:
the check of top PMP is redundant and will not influence the return
value, so consider remove it

Signed-off-by: Ruibo Lu <reaperlu@hust.edu.cn>
---
Reviewed-by: Weiwei Li <liweiwei@iscas.ac.cn>

Weiwei Li
  target/riscv/pmp.c | 5 -----
  1 file changed, 5 deletions(-)

diff --git a/target/riscv/pmp.c b/target/riscv/pmp.c
index 9d8db493e6..1a9279ba88 100644
--- a/target/riscv/pmp.c
+++ b/target/riscv/pmp.c
@@ -49,11 +49,6 @@ static inline int pmp_is_locked(CPURISCVState *env, uint32_t 
pmp_index)
          return 1;
      }
- /* Top PMP has no 'next' to check */
-    if ((pmp_index + 1u) >= MAX_RISCV_PMPS) {
-        return 0;
-    }
-
      return 0;
  }




reply via email to

[Prev in Thread] Current Thread [Next in Thread]