[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 1/6] tests/tcg/cris: Fix the coding style
From: |
Bin Meng |
Subject: |
[PATCH v4 1/6] tests/tcg/cris: Fix the coding style |
Date: |
Wed, 28 Jun 2023 23:27:21 +0800 |
The code style does not conform with QEMU's. Correct it so that the
upcoming commit does not trigger checkpatch warnings.
Signed-off-by: Bin Meng <bmeng@tinylab.org>
Acked-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
(no changes since v2)
Changes in v2:
- new patch: "tests/tcg/cris: Fix the coding style"
tests/tcg/cris/libc/check_openpf5.c | 57 ++++++++++++++---------------
1 file changed, 27 insertions(+), 30 deletions(-)
diff --git a/tests/tcg/cris/libc/check_openpf5.c
b/tests/tcg/cris/libc/check_openpf5.c
index 1f86ea283d..0037fbca4c 100644
--- a/tests/tcg/cris/libc/check_openpf5.c
+++ b/tests/tcg/cris/libc/check_openpf5.c
@@ -13,44 +13,41 @@
#include <fcntl.h>
#include <string.h>
-int main (int argc, char *argv[])
+int main(int argc, char *argv[])
{
- int i;
- int filemax;
+ int i;
+ int filemax;
#ifdef OPEN_MAX
- filemax = OPEN_MAX;
+ filemax = OPEN_MAX;
#else
- filemax = sysconf (_SC_OPEN_MAX);
+ filemax = sysconf(_SC_OPEN_MAX);
#endif
- char *fn = malloc (strlen (argv[0]) + 2);
- if (fn == NULL)
- abort ();
- strcpy (fn, "/");
- strcat (fn, argv[0]);
+ char *fn = malloc(strlen(argv[0]) + 2);
+ if (fn == NULL) {
+ abort();
+ }
+ strcpy(fn, "/");
+ strcat(fn, argv[0]);
- for (i = 0; i < filemax + 1; i++)
- {
- if (open (fn, O_RDONLY) < 0)
- {
- /* Shouldn't happen too early. */
- if (i < filemax - 3 - 1)
- {
- fprintf (stderr, "i: %d\n", i);
- abort ();
- }
- if (errno != EMFILE)
- {
- perror ("open");
- abort ();
- }
- goto ok;
- }
+ for (i = 0; i < filemax + 1; i++) {
+ if (open(fn, O_RDONLY) < 0) {
+ /* Shouldn't happen too early. */
+ if (i < filemax - 3 - 1) {
+ fprintf(stderr, "i: %d\n", i);
+ abort();
+ }
+ if (errno != EMFILE) {
+ perror("open");
+ abort();
+ }
+ goto ok;
+ }
}
- abort ();
+ abort();
ok:
- printf ("pass\n");
- exit (0);
+ printf("pass\n");
+ exit(0);
}
--
2.34.1
- [PATCH v4 0/6] net/tap: Fix QEMU frozen issue when the maximum number of file descriptors is very large, Bin Meng, 2023/06/28
- [PATCH v4 1/6] tests/tcg/cris: Fix the coding style,
Bin Meng <=
- [PATCH v4 2/6] tests/tcg/cris: Correct the off-by-one error, Bin Meng, 2023/06/28
- [PATCH v4 4/6] util/osdep: Introduce qemu_close_range(), Bin Meng, 2023/06/28
- [PATCH v4 6/6] net: tap: Use qemu_close_range() to close fds, Bin Meng, 2023/06/28
- [PATCH v4 3/6] util/async-teardown: Fall back to close fds one by one, Bin Meng, 2023/06/28
- [PATCH v4 5/6] util/async-teardown: Use qemu_close_range() to close fds, Bin Meng, 2023/06/28
- Re: [PATCH v4 0/6] net/tap: Fix QEMU frozen issue when the maximum number of file descriptors is very large, Michael Tokarev, 2023/06/29