[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 2/6] tests/tcg/cris: Correct the off-by-one error
From: |
Bin Meng |
Subject: |
[PATCH v4 2/6] tests/tcg/cris: Correct the off-by-one error |
Date: |
Wed, 28 Jun 2023 23:27:22 +0800 |
sysconf(_SC_OPEN_MAX) returns the maximum number of files that
a process can have open at any time, which means the fd should
not be larger than or equal to the return value.
Signed-off-by: Bin Meng <bmeng@tinylab.org>
Acked-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
(no changes since v2)
Changes in v2:
- new patch: "tests/tcg/cris: Correct the off-by-one error"
tests/tcg/cris/libc/check_openpf5.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/tcg/cris/libc/check_openpf5.c
b/tests/tcg/cris/libc/check_openpf5.c
index 0037fbca4c..7f585c6d37 100644
--- a/tests/tcg/cris/libc/check_openpf5.c
+++ b/tests/tcg/cris/libc/check_openpf5.c
@@ -31,10 +31,10 @@ int main(int argc, char *argv[])
strcpy(fn, "/");
strcat(fn, argv[0]);
- for (i = 0; i < filemax + 1; i++) {
+ for (i = 0; i < filemax; i++) {
if (open(fn, O_RDONLY) < 0) {
/* Shouldn't happen too early. */
- if (i < filemax - 3 - 1) {
+ if (i < filemax - 3) {
fprintf(stderr, "i: %d\n", i);
abort();
}
--
2.34.1
- [PATCH v4 0/6] net/tap: Fix QEMU frozen issue when the maximum number of file descriptors is very large, Bin Meng, 2023/06/28
- [PATCH v4 1/6] tests/tcg/cris: Fix the coding style, Bin Meng, 2023/06/28
- [PATCH v4 2/6] tests/tcg/cris: Correct the off-by-one error,
Bin Meng <=
- [PATCH v4 4/6] util/osdep: Introduce qemu_close_range(), Bin Meng, 2023/06/28
- [PATCH v4 6/6] net: tap: Use qemu_close_range() to close fds, Bin Meng, 2023/06/28
- [PATCH v4 3/6] util/async-teardown: Fall back to close fds one by one, Bin Meng, 2023/06/28
- [PATCH v4 5/6] util/async-teardown: Use qemu_close_range() to close fds, Bin Meng, 2023/06/28
- Re: [PATCH v4 0/6] net/tap: Fix QEMU frozen issue when the maximum number of file descriptors is very large, Michael Tokarev, 2023/06/29