[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH V3 2/2] migration: file URI offset
From: |
Peter Xu |
Subject: |
Re: [PATCH V3 2/2] migration: file URI offset |
Date: |
Wed, 28 Jun 2023 13:26:48 -0400 |
On Thu, Jun 22, 2023 at 01:37:31PM -0700, Steve Sistare wrote:
> Allow an offset option to be specified as part of the file URI, in
> the form "file:filename,offset=offset", where offset accepts the common
> size suffixes, or the 0x prefix, but not both. Migration data is written
> to and read from the file starting at offset. If unspecified, it defaults
> to 0.
>
> This is needed by libvirt to store its own data at the head of the file.
>
> Suggested-by: Daniel P. Berrange <berrange@redhat.com>
> Signed-off-by: Steve Sistare <steven.sistare@oracle.com>
Ideally I think we should make "," the separator from the start, but I
suppose no one will try to apply previous patch only, and then start using
a file name contains ",offset=".. so maybe not that a huge deal.
Reviewed-by: Peter Xu <peterx@redhat.com>
--
Peter Xu