[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH V3 2/2] migration: file URI offset
|
From: |
Steven Sistare |
|
Subject: |
Re: [PATCH V3 2/2] migration: file URI offset |
|
Date: |
Fri, 30 Jun 2023 10:25:18 -0400 |
|
User-agent: |
Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 |
On 6/29/2023 5:38 PM, Peter Xu wrote:
> On Thu, Jun 22, 2023 at 01:37:31PM -0700, Steve Sistare wrote:
>> +static int file_parse_offset(char *filespec, uint64_t *offsetp, Error
>> **errp)
>> +{
>> + char *option = strstr(filespec, OFFSET_OPTION);
>> + int ret;
>> +
>> + if (option) {
>> + *option = 0;
>> + option += sizeof(OFFSET_OPTION) - 1;
>> + ret = qemu_strtosz(option, NULL, offsetp);
>> + if (ret) {
>> + error_setg_errno(errp, ret, "file URI has bad offset %s",
>> option);
>
> Probably "-ret" here.
Yes, thanks.
I have submitted V4 with this fix and your RB's appended.
- Steve