[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 7/7] migration: Provide explicit error message for file shutdowns
From: |
Peter Xu |
Subject: |
[PATCH 7/7] migration: Provide explicit error message for file shutdowns |
Date: |
Wed, 28 Jun 2023 17:50:02 -0400 |
Provide an explicit reason for qemu_file_shutdown()s, which can be
displayed in query-migrate when used.
This will make e.g. migrate-pause to display explicit error descriptions,
from:
"error-desc": "Channel error: Input/output error"
To:
"error-desc": "Channel is explicitly shutdown by the user"
in query-migrate.
Signed-off-by: Peter Xu <peterx@redhat.com>
---
migration/qemu-file.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/migration/qemu-file.c b/migration/qemu-file.c
index 419b4092e7..ff605027de 100644
--- a/migration/qemu-file.c
+++ b/migration/qemu-file.c
@@ -87,7 +87,10 @@ int qemu_file_shutdown(QEMUFile *f)
* --> guest crash!
*/
if (!f->last_error) {
- qemu_file_set_error(f, -EIO);
+ Error *err = NULL;
+
+ error_setg(&err, "Channel is explicitly shutdown by the user");
+ qemu_file_set_error_obj(f, -EIO, err);
}
if (!qio_channel_has_feature(f->ioc,
--
2.41.0
- [PATCH 1/7] migration: Let migrate_set_error() take ownership, (continued)
- [PATCH 1/7] migration: Let migrate_set_error() take ownership, Peter Xu, 2023/06/28
- [PATCH 2/7] migration: Introduce migrate_has_error(), Peter Xu, 2023/06/28
- [PATCH 4/7] migration: Deliver return path file error to migrate state too, Peter Xu, 2023/06/28
- [PATCH 3/7] migration: Refactor error handling in source return path, Peter Xu, 2023/06/28
- [PATCH 6/7] qemufile: Always return a verbose error, Peter Xu, 2023/06/28
- [PATCH 5/7] migration: Display error in query-migrate irrelevant of status, Peter Xu, 2023/06/28
- [PATCH 7/7] migration: Provide explicit error message for file shutdowns,
Peter Xu <=