[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 5/7] migration: Display error in query-migrate irrelevant of
From: |
Peter Xu |
Subject: |
Re: [PATCH 5/7] migration: Display error in query-migrate irrelevant of status |
Date: |
Thu, 29 Jun 2023 15:56:39 -0400 |
On Wed, Jun 28, 2023 at 08:01:22PM -0300, Fabiano Rosas wrote:
> Peter Xu <peterx@redhat.com> writes:
>
> > Display it as long as being set, irrelevant of FAILED status. E.g., it may
> > also be applicable to PAUSED stage of postcopy, to provide hint on what has
> > gone wrong.
>
> This might have made the documentation slightly inaccurate:
Hmm yes, maybe I should touch that up so as to include "postcopy-paused",
or just remove the statement that it must be in a "failed" stage.
>
> # @error-desc: the human readable error description string, when
> # @status is 'failed'. Clients should not attempt to parse the
> # error strings. (Since 2.7)
>
> But it's not wrong, so:
>
> Reviewed-by: Fabiano Rosas <farosas@suse.de>
Thanks for taking a look.
--
Peter Xu
- [PATCH 0/7] migration: Better error handling in return path thread, Peter Xu, 2023/06/28
- [PATCH 1/7] migration: Let migrate_set_error() take ownership, Peter Xu, 2023/06/28
- [PATCH 2/7] migration: Introduce migrate_has_error(), Peter Xu, 2023/06/28
- [PATCH 4/7] migration: Deliver return path file error to migrate state too, Peter Xu, 2023/06/28
- [PATCH 3/7] migration: Refactor error handling in source return path, Peter Xu, 2023/06/28
- [PATCH 6/7] qemufile: Always return a verbose error, Peter Xu, 2023/06/28
- [PATCH 5/7] migration: Display error in query-migrate irrelevant of status, Peter Xu, 2023/06/28
- [PATCH 7/7] migration: Provide explicit error message for file shutdowns, Peter Xu, 2023/06/28