[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 12/14] file-posix: Fix zone update in I/O error path
From: |
Hanna Czenczek |
Subject: |
[PULL 12/14] file-posix: Fix zone update in I/O error path |
Date: |
Fri, 1 Sep 2023 10:19:21 +0200 |
We must check that zone information is present before running
update_zones_wp().
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2234374
Fixes: Coverity CID 1512459
Signed-off-by: Hanna Czenczek <hreitz@redhat.com>
Message-Id: <20230824155345.109765-4-hreitz@redhat.com>
Reviewed-by: Sam Li <faithilikerun@gmail.com>
---
block/file-posix.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/block/file-posix.c b/block/file-posix.c
index 46e22403fe..a050682e97 100644
--- a/block/file-posix.c
+++ b/block/file-posix.c
@@ -2525,7 +2525,8 @@ out:
}
}
} else {
- if (type & (QEMU_AIO_WRITE | QEMU_AIO_ZONE_APPEND)) {
+ if ((type & (QEMU_AIO_WRITE | QEMU_AIO_ZONE_APPEND)) &&
+ bs->bl.zoned != BLK_Z_NONE) {
update_zones_wp(bs, s->fd, 0, 1);
}
}
--
2.41.0
- [PULL 03/14] throttle: support read-only and write-only, (continued)
- [PULL 03/14] throttle: support read-only and write-only, Hanna Czenczek, 2023/09/01
- [PULL 01/14] throttle: introduce enum ThrottleDirection, Hanna Czenczek, 2023/09/01
- [PULL 04/14] test-throttle: test read only and write only, Hanna Czenczek, 2023/09/01
- [PULL 06/14] throttle: use enum ThrottleDirection instead of bool is_write, Hanna Czenczek, 2023/09/01
- [PULL 07/14] throttle: use THROTTLE_MAX/ARRAY_SIZE for hard code, Hanna Czenczek, 2023/09/01
- [PULL 05/14] cryptodev: use NULL throttle timer cb for read direction, Hanna Czenczek, 2023/09/01
- [PULL 08/14] fsdev: Use ThrottleDirection instread of bool is_write, Hanna Czenczek, 2023/09/01
- [PULL 10/14] file-posix: Clear bs->bl.zoned on error, Hanna Czenczek, 2023/09/01
- [PULL 11/14] file-posix: Check bs->bl.zoned for zone info, Hanna Czenczek, 2023/09/01
- [PULL 13/14] file-posix: Simplify raw_co_prw's 'out' zone code, Hanna Czenczek, 2023/09/01
- [PULL 12/14] file-posix: Fix zone update in I/O error path,
Hanna Czenczek <=
- [PULL 14/14] tests/file-io-error: New test, Hanna Czenczek, 2023/09/01
- [PULL 09/14] block/throttle-groups: Use ThrottleDirection instread of bool is_write, Hanna Czenczek, 2023/09/01
- Re: [PULL 00/14] Block patches, Stefan Hajnoczi, 2023/09/06