Re: [PULL 00/14] Block patches

[Hanna Czenczek]

On 07.09.23 13:21, Hanna Czenczek wrote:
> On 06.09.23 15:18, Stefan Hajnoczi wrote:
> > On Fri, 1 Sept 2023 at 04:18, Hanna Czenczek <hreitz@redhat.com> wrote:
> > > The following changes since commit 
> > > f5fe7c17ac4e309e47e78f0f9761aebc8d2f2c81:
> > >
> > >    Merge tag 'pull-tcg-20230823-2' of 
> > > https://gitlab.com/rth7680/qemu into staging (2023-08-28 16:07:04 
> > > -0400)
> > >
> > > are available in the Git repository at:
> > >
> > >    https://gitlab.com/hreitz/qemu.git tags/pull-block-2023-09-01
> > Hi Hanna,
> > Please push a signed tag (git tag -s). Thanks!

By the way, I meant to imply that I’m not going to push a new tag at 
this time.

I have generated this pull request as I always do, using a script that 
automatically signs the tag.  gpg asked me to enter my key password, 
indicating something had been signed, and the methods I know of tell me 
that the tag is indeed signed.  So as far as I can tell, the tag is 
signed as usual.  If I were to create a new pull request, I would do it 
the exact same way, which I expect would yield the same result, so we’d 
have the same problem again.

To get a different result, I need to know how you determine the tag not 
to be signed, so I can reproduce it and potentially fix the problem in 
my workflow.

Hanna

> Is it not signed?  I don’t think gitlab has support to show that, but 
> github shows it as verified: 
> https://github.com/XanClic/qemu/releases/tag/pull-block-2023-09-01
>
> And when I clone it:
> ```
> $ git clone https://gitlab.com/hreitz/qemu -b pull-block-2023-09-01 
> --depth=1
> [...]
> $ cd qemu
> $ git tag -v pull-block-2023-09-01
> LANG=C git tag -v pull-block-2023-09-01
> object 380448464dd89291cf7fd7434be6c225482a334d
> type commit
> tag pull-block-2023-09-01
> tagger Hanna Reitz <hreitz@redhat.com> 1693555853 +0200
>
> Block patches
>
> - Fix for file-posix's zoning code crashing on I/O errors
> - Throttling refactoring
> gpg: Signature made Fri Sep  1 10:11:46 2023 CEST
> gpg:                using RSA key 
> CB62D7A0EE3829E45F004D34A1FA40D098019CDF
> gpg:                issuer "hreitz@redhat.com"
> gpg: Good signature from "Hanna Reitz <hreitz@redhat.com>" [ultimate]
> Primary key fingerprint: CB62 D7A0 EE38 29E4 5F00  4D34 A1FA 40D0 9801 
> 9CDF
> ```
>
> Hanna