Re: [PATCH 1/4] sysemu/kvm: Restrict kvmppc_get_radix_page_info() to ppc targets

[Philippe Mathieu-Daudé]

On 12/9/23 14:32, Michael Tokarev wrote:
> 12.09.2023 14:30, Philippe Mathieu-Daudé:
> > kvm_get_radix_page_info() is only defined for ppc targets (in
> > target/ppc/kvm.c). The declaration is not useful in other targets.
> > Rename using the 'kvmppc_' prefix following other declarations
> > from target/ppc/kvm_ppc.h.
> >
> > Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> > ---
> >   include/sysemu/kvm.h | 1 -
> >   target/ppc/kvm_ppc.h | 2 ++
> >   target/ppc/kvm.c     | 4 ++--
> >   3 files changed, 4 insertions(+), 3 deletions(-)


> I wonder, if it's defined and used in target/ppc/kvm.c only,
> why it needs to be in an .h file to begin with, instead of being static?

Good point, I didn't noticed.
It is this way since it's introduction in commit c64abd1f9c
("spapr: Add ibm,processor-radix-AP-encodings to the device tree").

I'll respin after waiting for more review, thanks!

Phil.