qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 4/8] hw/core/cpu: Return static value with gdb_arch_name()


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH 4/8] hw/core/cpu: Return static value with gdb_arch_name()
Date: Mon, 4 Sep 2023 07:12:09 +0200
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.15.0

On 3/9/23 06:30, Akihiko Odaki wrote:
All implementations of gdb_arch_name() returns dynamic duplicates of
static strings. It's also unlikely that there will be an implementation
of gdb_arch_name() that returns a truly dynamic value due to the nature
of the function returning a well-known identifiers. Qualify the value
gdb_arch_name() with const and make all of its implementations return
static strings.

Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
---
  include/hw/core/cpu.h  | 2 +-
  target/ppc/internal.h  | 2 +-
  gdbstub/gdbstub.c      | 4 +---
  target/arm/cpu.c       | 6 +++---
  target/arm/cpu64.c     | 4 ++--
  target/i386/cpu.c      | 6 +++---
  target/loongarch/cpu.c | 4 ++--
  target/ppc/gdbstub.c   | 6 +++---
  target/riscv/cpu.c     | 6 +++---
  target/s390x/cpu.c     | 4 ++--
  target/tricore/cpu.c   | 4 ++--
  11 files changed, 23 insertions(+), 25 deletions(-)

Nice.

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]