|
From: | Michael Tokarev |
Subject: | Re: [PATCH 4/8] hw/core/cpu: Return static value with gdb_arch_name() |
Date: | Mon, 4 Sep 2023 08:54:09 +0300 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 |
03.09.2023 07:30, Akihiko Odaki wrote:
All implementations of gdb_arch_name() returns dynamic duplicates of static strings. It's also unlikely that there will be an implementation of gdb_arch_name() that returns a truly dynamic value due to the nature of the function returning a well-known identifiers. Qualify the value gdb_arch_name() with const and make all of its implementations return static strings.
Why it needs to be a function, can't it be a char pointer initialized at the cpu init time? Reviewed-By: Michael Tokarev <mjt@tls.msk.ru> (What a huge list of recipients in the Cc..) /mjt
[Prev in Thread] | Current Thread | [Next in Thread] |