Re: [RFC PATCH 1/3] Python: Drop support for Python 3.7

[Paolo Bonzini]

Il lun 4 set 2023, 12:34 Philippe Mathieu-Daudé <philmd@linaro.org> ha scritto:

> Since it is safe to under our supported platform policy, bump our

Is 'under' a verb? This sentence is not obvious to me.

No, just drop "to".

Paolo

> minimum supported version of Python to 3.8.  The two most interesting
> features to have by default include:
>
> - the importlib.metadata module, whose lack is responsible for over 100
>    lines of code in mkvenv.py
>
> - improvements to asyncio, for example asyncio.CancelledError
>    inherits from BaseException rather than Exception
>
> In addition, code can now use the assignment operator ':='
>
> Because mypy now learns about importlib.metadata, a small change to
> mkvenv.py is needed to pass type checking.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>   configure                | 8 ++++----
>   python/Makefile          | 8 ++++----
>   python/scripts/mkvenv.py | 5 ++++-
>   python/setup.cfg         | 7 +++----
>   python/tests/minreqs.txt | 2 +-
>   scripts/qapi/mypy.ini    | 2 +-
>   6 files changed, 17 insertions(+), 15 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>