[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 04/21] hw/cpu: Update the comments of nr_cores and nr_dies
From: |
Zhao Liu |
Subject: |
Re: [PATCH v4 04/21] hw/cpu: Update the comments of nr_cores and nr_dies |
Date: |
Fri, 15 Sep 2023 15:40:25 +0800 |
On Thu, Sep 14, 2023 at 09:32:31AM +0200, Philippe Mathieu-Daudé wrote:
> Date: Thu, 14 Sep 2023 09:32:31 +0200
> From: Philippe Mathieu-Daudé <philmd@linaro.org>
> Subject: Re: [PATCH v4 04/21] hw/cpu: Update the comments of nr_cores and
> nr_dies
>
> On 14/9/23 09:21, Zhao Liu wrote:
> > From: Zhao Liu <zhao1.liu@intel.com>
> >
> > In the nr_threads' comment, specify it represents the
> > number of threads in the "core" to avoid confusion.
> >
> > Also add comment for nr_dies in CPUX86State.
> >
> > Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
> > ---
> > Changes since v3:
> > * The new patch split out of CPUSTATE.nr_cores' fix. (Xiaoyao)
> > ---
> > include/hw/core/cpu.h | 2 +-
> > target/i386/cpu.h | 1 +
> > 2 files changed, 2 insertions(+), 1 deletion(-)
>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>
Thanks!
-Zhao
- [PATCH v4 00/21] Support smp.clusters for x86 in QEMU, Zhao Liu, 2023/09/14
- [PATCH v4 03/21] softmmu: Fix CPUSTATE.nr_cores' calculation, Zhao Liu, 2023/09/14
- [PATCH v4 02/21] tests: Rename test-x86-cpuid.c to test-x86-topo.c, Zhao Liu, 2023/09/14
- [PATCH v4 01/21] i386: Fix comment style in topology.h, Zhao Liu, 2023/09/14
- [PATCH v4 04/21] hw/cpu: Update the comments of nr_cores and nr_dies, Zhao Liu, 2023/09/14
- [PATCH v4 05/21] i386/cpu: Fix i/d-cache topology to core level for Intel CPU, Zhao Liu, 2023/09/14
- [PATCH v4 07/21] i386/cpu: Consolidate the use of topo_info in cpu_x86_cpuid(), Zhao Liu, 2023/09/14
- [PATCH v4 08/21] i386: Split topology types of CPUID[0x1F] from the definitions of CPUID[0xB], Zhao Liu, 2023/09/14
- [PATCH v4 06/21] i386/cpu: Use APIC ID offset to encode cache topo in CPUID[4], Zhao Liu, 2023/09/14
- [PATCH v4 10/21] i386: Introduce module-level cpu topology to CPUX86State, Zhao Liu, 2023/09/14
- [PATCH v4 11/21] i386: Support modules_per_die in X86CPUTopoInfo, Zhao Liu, 2023/09/14
- [PATCH v4 09/21] i386: Decouple CPUID[0x1F] subleaf with specific topology level, Zhao Liu, 2023/09/14
- [PATCH v4 12/21] i386: Expose module level in CPUID[0x1F], Zhao Liu, 2023/09/14