Re: [PULL 2/3] seabios: turn off CONFIG_APMBIOS for 128k build

[Gerd Hoffmann]

On Tue, Sep 12, 2023 at 03:55:03PM +0200, Paolo Bonzini wrote:
> On 9/12/23 12:53, Gerd Hoffmann wrote:
> > Needed to make the build fit into 128k.
> > 
> > Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> > ---
> >   roms/config.seabios-128k | 1 +
> >   1 file changed, 1 insertion(+)
> > 
> > diff --git a/roms/config.seabios-128k b/roms/config.seabios-128k
> > index d18c802c46e9..bc3ba7f65bcd 100644
> > --- a/roms/config.seabios-128k
> > +++ b/roms/config.seabios-128k
> > @@ -19,3 +19,4 @@ CONFIG_USE_SMM=n
> >   CONFIG_VGAHOOKS=n
> >   CONFIG_HOST_BIOS_GEOMETRY=n
> >   CONFIG_ACPI_PARSE=n
> > +CONFIG_APMBIOS=n
> 
> Why don't we instead drop ``pc-i440fx-1.4`` up to ``pc-i440fx-1.7``, which
> have been deprecated since 7.0?  We cannot get rid of the 128k ROM because
> isapc uses it, but we can remove PCI and ACPI from it, and solve the size
> problem once and for all.

I happily update the seabios config once the old machine types are gone.

take care,
  Gerd