Re: [PULL 0/3] Firmware/seabios 20230912 patches

[Daniel P . Berrangé]

On Mon, Sep 18, 2023 at 08:52:57AM -0400, Stefan Hajnoczi wrote:
> On Mon, 18 Sept 2023 at 06:00, Gerd Hoffmann <kraxel@redhat.com> wrote:
> >
> > > Hi Gerd,
> > > I think either this pull request or your edk2 pull request causes the
> > > following CI failure:
> > >
> > > >>> G_TEST_DBUS_DAEMON=/builds/qemu-project/qemu/tests/dbus-vmstate-daemon.sh
> > > >>>  QTEST_QEMU_BINARY=./qemu-system-aarch64 MALLOC_PERTURB_=199 
> > > >>> /builds/qemu-project/qemu/build/tests/qtest/bios-tables-test --tap -k
> > > ――――――――――――――――――――――――――――――――――――― ✀ 
> > > ―――――――――――――――――――――――――――――――――――――
> >
> > Address change in ACPI tables (edk2 PR):
> >
> >      DefinitionBlock ("", "SSDT", 1, "BOCHS ", "NVDIMM", 0x00000001)
> >      {
> >          Scope (\_SB)
> >          {
> >              Device (NVDR)
> >              {
> >                  Name (_HID, "ACPI0012" /* NVDIMM Root Device */)  // _HID: 
> > Hardware ID
> >                  [ ... ]
> >              }
> >          }
> >
> >     -    Name (MEMA, 0x43D10000)
> >     +    Name (MEMA, 0x43C90000)
> >      }
> >
> > seabios PR is fine and passes "make check".
> 
> I'm still seeing a CI failure:
> 
> 3/61 qemu:qtest+qtest-x86_64 / qtest-x86_64/bios-tables-test ERROR
> 19.18s killed by signal 6 SIGABRT
> ――――――――――――――――――――――――――――――――――――― ✀ ―――――――――――――――――――――――――――――――――――――
> stderr:
> acpi-test: Warning! DSDT binary file mismatch. Actual
> [aml:/var/folders/76/zy5ktkns50v6gt5g8r0sf6sc0000gn/T/aml-SW7IB2],
> Expected [aml:tests/data/acpi/q35/DSDT.mmio64].
> See source file tests/qtest/bios-tables-test.c for instructions on how
> to update expected files.
> to see ASL diff between mismatched files install IASL, rebuild QEMU
> from scratch and re-run tests with V=1 environment variable set**
> ERROR:../tests/qtest/bios-tables-test.c:535:test_acpi_asl: assertion
> failed: (all_tables_match)

Hmm, that's rather unhelpful - we need to get iasl added to the build
env by default.

> (test program exited with status code -6)
> 
> https://gitlab.com/qemu-project/qemu/-/jobs/5110608123

Note this is a aarch64 macOS environment

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|